[U-Boot] [PATCH] drivers: net: ldpaa_eth: Correct error handler for qbman_swp_acquire()

Ashish Kumar ashish.kumar at nxp.com
Tue Oct 31 05:19:45 UTC 2017


Please see inline.

-----Original Message-----
From: York Sun 
Sent: Tuesday, October 31, 2017 12:32 AM
To: Ashish Kumar <ashish.kumar at nxp.com>; Roy Pledge <roy.pledge at nxp.com>
Cc: joe.hershberger at gmail.com; Prabhakar Kushwaha <prabhakar.kushwaha at nxp.com>; u-boot at lists.denx.de
Subject: Re: [PATCH] drivers: net: ldpaa_eth: Correct error handler for qbman_swp_acquire()

On 10/29/2017 10:23 PM, Ashish Kumar wrote:
> Hello York,
> 
> The definition of qbman_swp_acquire(), is not owned by u-boot, it is part of qbman drivers which is owned by Roy.
> u-boot gets this definition from flib code and same is used in u-boot as it is.
> 
> So, moving this error handler in qbman_swp_acquire for num == 0, may result in inconsistency in flib code that was provided at the time of integration.
> 

OK. Let's keep it that way.
BTW, please do not top post if you can avoid it. Please always use common quotation style when you reply.

Sure, I will take care.

York


More information about the U-Boot mailing list