[U-Boot] About the way to fix platform specific issue in source file xhci.c (U-Boot)

[Marek Vasut]

On 10/31/2017 10:15 AM, Ran Wang wrote:
> Hi Marek,

Hi!

>> -----Original Message-----
>> From: Marek Vasut [mailto:marex at denx.de]
>> Sent: Monday, October 30, 2017 6:55 PM
>> To: Ran Wang <ran.wang_1 at nxp.com>
>> Cc: bmeng.cn at gmail.com
>> Subject: Re: About the way to fix platform specific issue in source file xhci.c
>> (U-Boot)
>>
>> On 10/30/2017 09:39 AM, Ran Wang wrote:
>>> Hi Vasut,
>>>    For git://git.denx.de/u-boot-usb.git, I work out a patch to fix USB issue
>> which will happen on SoC LS2080A only (it's using DWC3).
>>>    Per my understanding, we should not use platform define in xhci.c to
>> control its effect. However, I am not sure how to do it that can be accepted
>> by upstream, so send you this mail for suggestion before I post the patch to
>> patchwork. Thank you in advance.
>>
>> This should be fixed in common code, not in drivers. 
> 
> Did you mean it should be fixed in common/usb*.c rather than drivers/usb/*?

Yes

> If yes, is it acceptable that I use 'if defined(CONFIG_ARCH_LS2080A)' in common/usb.c?

No

> If answer is no, how should I do? I cannot find an example and not sure it's OK 
> to related rule.

What is the problem exactly ?
I recall there were reports of shitty USB sticks failing, but without
further details, it's hard to tell if this is the same problem.

[...]

-- 
Best regards,
Marek Vasut