[U-Boot] [PATCH v3] rpi: Enable USB keyboard support

Tom Rini trini at konsulko.com
Fri Sep 1 14:52:30 UTC 2017


On Thu, Aug 31, 2017 at 08:52:34PM +0800, Simon Glass wrote:
> Hi Alex,
> 
> On 28 August 2017 at 18:10, Alexander Graf <agraf at suse.de> wrote:
> >
> >
> >> Am 26.08.2017 um 19:43 schrieb Simon Glass <sjg at chromium.org>:
> >>
> >> This is currently disabled, so USB keyboards are not detected in U-Boot.
> >> Enable this option to fix that.
> >>
> >> Signed-off-by: Simon Glass <sjg at chromium.org>
> >> Tested-by: Jonathan Gray <jsg at jsg.id.au>
> >> Reviewed-by: Bin Meng <bmeng.cn at gmail.com>
> >> Tested-by: Paul Barker <pbarker at toganlabs.com>
> >
> > When did the default behavior on kbd usb support change? I'd be inclined to say that we should restore the exact same functionality scope as before for all affected boards, not just a few well tested ones ;).
> >
> > In fact, wouldn't it make sense to imply usb kbd support in kconfig always when usb (and gfx?) is present?
> 
> Well I think it is odd to have to enable this option separately when
> you already have decided to use the keyboard. I'm not sure what to do
> in the interim, but once everything is using DM, we will drop
> CONFIG_DM_KEYBOARD. So this is really just an interim state.
> 
> I don't have strong views either way.

If someone wants to cook up a patch to add 'imply USB_KEYBOARD' in the
right places we can do it that way for now certainly.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170901/3301ee98/attachment.sig>


More information about the U-Boot mailing list