[U-Boot] [PATCH v3 1/1] usb: gadget: g_dnl: Sync internal SN variable with env

Łukasz Majewski lukma at denx.de
Tue Sep 5 10:27:37 UTC 2017


Hi Sam,

> On 4 September 2017 at 08:36, Heiko Schocher <hs at denx.de> wrote:
>> Hello Lukasz,
>>
>> Am 02.09.2017 um 13:08 schrieb Łukasz Majewski:
>>>
>>> Hi Heiko,
>>>
>>> Would you find some time and run this patch through your test setup?
>>>
>>> Thanks in advance.
>>
>>
>> Of course, as it is automated ;-)
>>
>> Okay, I had to add an oneliner, to say tbot, which patchwork patch it
>> has to download... for the records see [1].
>>
>> Here the results for the smartweb board (in short, my dfu test are
>> working with this patch):
>>
>> http://xeidos.ddns.net/tests/test_db_auslesen.php#408
>>
>> Logs:
>> http://xeidos.ddns.net/tbot/id_408/html_log.html
>>
>> Especially the steps:
>>
>> (download patchwork patch, check with checkpatch, apply to mainline):
>> http://xeidos.ddns.net/tbot/id_408/html_log.html#92
>> http://xeidos.ddns.net/tbot/id_408/html_log.html#95
>> http://xeidos.ddns.net/tbot/id_408/html_log.html#98
>>
>> and the dfu test:
>>
>> http://xeidos.ddns.net/tbot/id_408/html_log.html#398
>> http://xeidos.ddns.net/tbot/id_408/html_log.html#409
>> http://xeidos.ddns.net/tbot/id_408/html_log.html#413
>> http://xeidos.ddns.net/tbot/id_408/html_log.html#417
>>
>> My browser (firefox) seems to have problems with jumping to the correct
>> "id"s in the html file ...
>>
>> Hope you can find the logs, if not, look into the raw logfile:
>>
>> http://xeidos.ddns.net/tbot/id_408/tbot.txt
>>
>> but this is not very comfortable ...
>>
>> So, please add my:
>>
>> Tested-by: Heiko Schocher <hs at denx.de>
>>
> 
> Hi Lukasz,
> 
> Now that testing is done (thanks Heiko!), can you please Ack or Review
> this patch? I really want it to go in v2017.09 release, as it's
> critical bug fix for us.

No problem from my side:

Acked-by: Łukasz Majewski <lukma at denx.de>


If Marek don't mind - I would like to ask Tom to apply it directly to 
-master branch (because of the patch importance).


> 
> Thanks!
> 
>> bye,
>> Heiko
>>
>> [1] tbot patch for adding a patchworkpatch
>>
>> root at raspberrypi:/home/pi/data/tbot# git diff
>> diff --git a/config/smartweb.py b/config/smartweb.py
>> index 72a7972..98c8e0f 100644
>> --- a/config/smartweb.py
>> +++ b/config/smartweb.py
>> @@ -37,6 +37,8 @@ tc_workfd_apply_patchwork_patches_list_hand = [
>> ]
>> tc_workfd_apply_patchwork_patches_blacklist = ['204183', '561384']
>>
>> +tc_workfd_apply_patchwork_patches_list = ['808671']
>> +
>> uboot_get_parameter_file_list = ['.config', 'include/configs/smartweb.h',
>> 'arch/arm/mach-at91/include/mach/at91sam9260.h']
>>
>> tc_workfd_set_toolchain_arch = 'arm'
>> root at raspberrypi:/home/pi/data/tbot#
>>
>>
>> --
>> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
>> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> 


-- 
Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de


More information about the U-Boot mailing list