[U-Boot] [PATCH v2 7/8] fat/fs: move ls to generic implementation

Rob Clark robdclark at gmail.com
Wed Sep 6 02:12:02 UTC 2017


On Tue, Sep 5, 2017 at 4:56 AM, Simon Glass <sjg at chromium.org> wrote:
> On 3 September 2017 at 00:38, Rob Clark <robdclark at gmail.com> wrote:
>> Add a generic implementation of 'ls' using opendir/readdir/closedir, and
>> replace fat's custom implementation.  Other filesystems should move to
>> the generic implementation after they add opendir/readdir/closedir
>> support.
>>
>> Signed-off-by: Rob Clark <robdclark at gmail.com>
>> ---
>>  fs/fat/fat.c  | 32 --------------------------------
>>  fs/fs.c       | 35 +++++++++++++++++++++++++++++++++--
>>  include/fat.h |  5 ++++-
>>  3 files changed, 37 insertions(+), 35 deletions(-)
>
> Reviewed-by: Simon Glass <sjg at chromium.org>
>
> So if all filesystems implement this interface then we could move this
> to function to the fs layer?

yes.. there are some slight differences in output for other fs's but I
guess since u-boot doesn't make that easy for a script to capture we
can probably ignore it..

BR,
-R


More information about the U-Boot mailing list