[U-Boot] [PATCH 2/2] rockchip: ram: rk3399: update reg map for of-platdata

[Dr. Philipp Tomsich]

> On 8 Sep 2017, at 04:46, Kever Yang <kever.yang at rock-chips.com> wrote:
> 
> Philipp,
> 
>    We already enable CONFIG_SPL_OF_CONTROL for all rk3399 board, right?

I meant “full OF_CONTROL” as opposed to “OF_PLATDATA” (which is dependent
of OF_CONTROL, but is intended as a stopgap measure).

>    For OF_PLATDATA, I would prefer there always have a  option to use for
> speed up the boot time, not only for ram size.

I had discussed that with Simon recently and he views OF_PLATDATA as a last
resort to be used, when there is not enough memory for full OF_CONTROL.


> Thanks,
> - Kever
> On 09/07/2017 04:51 PM, Dr. Philipp Tomsich wrote:
>> Kever,
>> 
>> Thanks for the fix.
>> 
>> Could we move all RK3399 boards to use OF_CONTROL (i.e. not OF_PLATDATA)
>> in SPL?  We have been using this for the RK3399-Q7 and there is plenty of SRAM
>> left for future code-growth, so this should be a safe choice.
>> 
>> Regards,
>> Philipp.
>> 
>>> On 7 Sep 2017, at 05:20, Kever Yang <kever.yang at rock-chips.com> wrote:
>>> 
>>> After Simon's patch, the dtoc can work with 64bit address,
>>> so we need to fix reg number for it.
>>> Depend on Simon's patch set:
>>> https://patchwork.ozlabs.org/cover/807266/
>>> 
>>> Signed-off-by: Kever Yang <kever.yang at rock-chips.com>
>> Reviewed-by: Philipp Tomsich <philipp.tomsich at theobroma-systems.com>
>> 
>>> ---
>>> 
>>> drivers/ram/rockchip/sdram_rk3399.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>> 
>>> diff --git a/drivers/ram/rockchip/sdram_rk3399.c b/drivers/ram/rockchip/sdram_rk3399.c
>>> index 63342ab..5ed4b03 100644
>>> --- a/drivers/ram/rockchip/sdram_rk3399.c
>>> +++ b/drivers/ram/rockchip/sdram_rk3399.c
>>> @@ -1115,7 +1115,7 @@ static int conv_of_platdata(struct udevice *dev)
>>> 	int ret;
>>> 
>>> 	ret = regmap_init_mem_platdata(dev, dtplat->reg,
>>> -			ARRAY_SIZE(dtplat->reg) / 4,
>>> +			ARRAY_SIZE(dtplat->reg) / 2,
>>> 			&plat->map);
>>> 	if (ret)
>>> 		return ret;
>>> -- 
>>> 1.9.1
>>> 
>> 
> 
>