[U-Boot] [U-Boot,v2,2/5] rockchip: rk322x: add sdram driver

Simon Glass sjg at chromium.org
Sat Sep 9 04:54:54 UTC 2017


Hi Philipp,

On 5 September 2017 at 03:51, Philipp Tomsich
<philipp.tomsich at theobroma-systems.com> wrote:
> + Simon
>
> Kever,
>
> thanks for moving this to the new location, but it doesn't address my
> concerns that we are duplicating large amounts of code from other SDRAM
> drivers (and that there's large amounts of #define statements where we
> usually use enum definitions for Rockchip).
>
> You may be able to convince me to apply this to the 'next' branch as-is, if
> we get a plan in place to clean up the DRAM controller code over during the
> two merge windows remaining in this year.
>
> @Simon: I know the amount of code-duplication across the DRAM controller
> drivers is a touchy subject for you too --- any additional comments or
> guidance?

Well I haven't changed my mind. I think it would be good to make a
start before any more drivers go in.

But I should leave the specifics to you.

Regards,
Simon


More information about the U-Boot mailing list