[U-Boot] [PATCH v3 2/4] block: ide: Fix block read/write with driver model

[Bin Meng]

Hi Tom,

On Sat, Sep 9, 2017 at 11:25 AM, Tom Rini <trini at konsulko.com> wrote:
> On Sat, Sep 09, 2017 at 08:30:44AM +0800, Bin Meng wrote:
>> Hi Tom,
>>
>> On Wed, Sep 6, 2017 at 3:30 PM, Bin Meng <bmeng.cn at gmail.com> wrote:
>> > This converts the IDE driver to driver model so that block read and
>> > write are fully functional.
>> >
>> > Fixes: b7c6baef ("x86: Convert MMC to driver model")
>> > Reported-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
>> > Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
>> >
>> > Reviewed-by: Simon Glass <sjg at chromium.org>
>> > Tested-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
>> > ---
>> >
>> > Changes in v3:
>> > - Updated BLK_XXX_SIZE usage
>> >
>> > Changes in v2:
>> > - Fixed 'fatls ide 0' issue
>> >
>> >  drivers/block/blk-uclass.c |  2 +-
>> >  drivers/block/ide.c        | 70 ++++++++++++++++++++++++++++++++++++++++++++++
>> >  include/dm/uclass-id.h     |  1 +
>> >  3 files changed, 72 insertions(+), 1 deletion(-)
>> >
>>
>> Will you take this series in 2017.09?
>
> I would swear that we declare vendor/etc as size + 1 so that we can
> ensure that size+1==NULL and only write up to size into the field.  But
> the rest of this patch strncpy's to size+1.  That feels wrong, but I'm
> not totally sure.  Are you?  Thanks!
>

OK, v4 was just sent. Please take a look and hope it makes it before
the release.

Regards,
Bin