[U-Boot] [PATCH 09/10] rockchip: evb-rk3229: add README file for OP-TEE support

[Simon Glass]

Hi Kever,

On 5 September 2017 at 20:14, Kever Yang <kever.yang at rock-chips.com> wrote:
> Detail of step by step to bring up the board with OP-TEE support.
>
> Signed-off-by: Kever Yang <kever.yang at rock-chips.com>
> ---
>
>  board/rockchip/evb_rk3229/README | 72 ++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 72 insertions(+)
>  create mode 100644 board/rockchip/evb_rk3229/README
>
> diff --git a/board/rockchip/evb_rk3229/README b/board/rockchip/evb_rk3229/README
> new file mode 100644
> index 0000000..93328c7
> --- /dev/null
> +++ b/board/rockchip/evb_rk3229/README
> @@ -0,0 +1,72 @@

Can you add an overall header at the top of the file?

- what is OP-TEE
- what is the point of all this
- what pieces are needed
- what the tools are for (rkdeveloptool, rkbin)

nit: I think it is better to use============= for the top header and
-------------- for the subheaders (which are below)

> +Get the Source and prebuild binary
> +==================================
> +
> +  > mkdir ~/evb_rk3229
> +  > cd ~/evb_rk3229
> +  > git clone git://git.denx.de/u-boot.git
> +  > git clone https://github.com/OP-TEE/optee_os.git
> +  > git clone https://github.com/rockchip-linux/rkbin.git
> +  > git clone https://github.com/rockchip-linux/rkdeveloptool.git
> +
> +Compile the OP-TEE
> +===============
> +
> +  > cd optee_os
> +  > make clean
> +  > make CROSS_COMPILE_ta_arm32=arm-none-eabi- PLATFORM=rockchip-rk322x
> +  Get tee.bin in this step, copy it to U-Boot root dir:
> +  > cp out/arm-plat-rockchip/core/tee-pager.bin ../u-boot/tee.bin
> +
> +Compile the U-Boot

Build U-Boot

(since it compiles but also does other steps)

> +==================
> +
> +  > cd ../u-boot
> +  > export CROSS_COMPILE=arm-linux-gnueabihf-
> +  > export ARCH=arm
> +  > make evb-rk3229_defconfig
> +  > make
> +  > make u-boot.itb
> +
> +  Get tpl/u-boot-tpl.bin, spl/u-boot-spl.bin and u-boot.itb in this step.
> +
> +Compile the rkdeveloptool
> +=======================
> +  Follow instructions in latest README
> +  > cd ../rkflashtool
> +  > autoreconf -i
> +  > ./configure
> +  > make
> +  > sudo make install
> +
> +  Get rkdeveloptool in you Host in this step.

How about: Install rkdeveloptool on your host as follows

(above you could put that at the top of this section)

> +
> +Both origin binaries and Tool are ready now, choose either option 1 or
> +option 2 to deploy U-Boot.

Where are the two options. If they are below, please number them 1 and 2.

> +
> +Package the image
> +=================
> +
> +  > cd ../u-boot
> +  > tools/mkimage -n rk322x -T rksd -d tpl/u-boot-spl.bin idbloader.img
> +  > cat spl/u-boot-spl.bin >> idbloader.img
> +
> +  Get idbloader.img in this step.

Put at top under 'Package the image'

> +
> +Flash the image to eMMC
> +=======================
> +Power on(or reset with RESET KEY) with MASKROM KEY preesed, and then:
> +  > cd ..
> +  > rkdeveloptool db rkbin/rk32/rk322x_loader_v1.04.232.bin
> +  > rkdeveloptool wl 64 u-boot/idbloader.img
> +  > rkdeveloptool wl 0x4000 u-boot/u-boot.itb
> +  > rkdeveloptool rd
> +
> +Flash the image to SD card
> +==========================
> +  > dd if=u-boot/idbloader.img of=/dev/sdb seek=64
> +  > dd if=u-boot/u-boot.itb of=/dev/sdb seek=16384
> +
> +You should be able to get U-Boot log message with OP-TEE boot info.

s/log/console/

Can you please add an example console message here?

> +
> +For more detail, please reference to:
> +http://opensource.rock-chips.com/wiki_Boot_option
> --
> 1.9.1
>

Regards,
Simon