[U-Boot] [PATCH 05/13] usb: gadget: Make g_dnl USB settings common

Simon Glass sjg at chromium.org
Tue Sep 12 12:28:08 UTC 2017


Hi Maxime,

On 8 September 2017 at 11:34, Maxime Ripard
<maxime.ripard at free-electrons.com> wrote:
> The g_dnl USB settings for the vendor ID, product ID and manufacturer are
> actually common settings that can and should be shared by all the gadgets.
>
> Make them common by renaming them, and convert all the users.
>
> Signed-off-by: Maxime Ripard <maxime.ripard at free-electrons.com>
> ---
>  board/samsung/common/gadget.c                    |  4 ++--
>  board/siemens/common/factoryset.c                |  4 ++--
>  configs/A13-OLinuXino_defconfig                  |  6 +++---
>  configs/A20-OLinuXino-Lime2-eMMC_defconfig       |  6 +++---
>  configs/A20-OLinuXino-Lime2_defconfig            |  6 +++---
>  configs/CHIP_defconfig                           |  6 +++---
>  configs/CHIP_pro_defconfig                       |  6 +++---
>  configs/Cubietruck_defconfig                     |  6 +++---
>  configs/Nintendo_NES_Classic_Edition_defconfig   |  6 +++---
>  configs/Sinlinx_SinA33_defconfig                 |  6 +++---
>  configs/am335x_baltos_defconfig                  |  6 +++---
>  configs/am335x_boneblack_defconfig               |  6 +++---
>  configs/am335x_boneblack_vboot_defconfig         |  6 +++---
>  configs/am335x_evm_defconfig                     |  6 +++---
>  configs/am335x_evm_nor_defconfig                 |  6 +++---
>  configs/am335x_evm_norboot_defconfig             |  6 +++---
>  configs/am335x_evm_spiboot_defconfig             |  6 +++---
>  configs/am335x_evm_usbspl_defconfig              |  6 +++---
>  configs/am335x_hs_evm_defconfig                  |  6 +++---
>  configs/am43xx_evm_defconfig                     |  6 +++---
>  configs/am43xx_evm_ethboot_defconfig             |  6 +++---
>  configs/am43xx_evm_qspiboot_defconfig            |  6 +++---
>  configs/am43xx_evm_usbhost_boot_defconfig        |  6 +++---
>  configs/am43xx_hs_evm_defconfig                  |  6 +++---
>  configs/am57xx_evm_defconfig                     |  6 +++---
>  configs/am57xx_evm_nodt_defconfig                |  6 +++---
>  configs/am57xx_hs_evm_defconfig                  |  6 +++---
>  configs/apalis-tk1_defconfig                     |  6 +++---
>  configs/apalis_imx6_defconfig                    |  6 +++---
>  configs/apalis_imx6_nospl_com_defconfig          |  6 +++---
>  configs/apalis_imx6_nospl_it_defconfig           |  6 +++---
>  configs/apalis_t30_defconfig                     |  6 +++---
>  configs/bcm11130_defconfig                       |  6 +++---
>  configs/bcm11130_nand_defconfig                  |  6 +++---
>  configs/bcm23550_w1d_defconfig                   |  6 +++---
>  configs/bcm28155_ap_defconfig                    |  6 +++---
>  configs/bcm28155_w1d_defconfig                   |  6 +++---
>  configs/beaver_defconfig                         |  6 +++---
>  configs/birdland_bav335a_defconfig               |  6 +++---
>  configs/birdland_bav335b_defconfig               |  6 +++---
>  configs/cei-tk1-som_defconfig                    |  6 +++---
>  configs/cgtqmx6eval_defconfig                    |  6 +++---
>  configs/chromebit_mickey_defconfig               |  6 +++---
>  configs/chromebook_jerry_defconfig               |  6 +++---
>  configs/chromebook_minnie_defconfig              |  6 +++---
>  configs/colibri_imx6_defconfig                   |  6 +++---
>  configs/colibri_imx6_nospl_defconfig             |  6 +++---
>  configs/colibri_imx7_defconfig                   |  6 +++---
>  configs/colibri_t20_defconfig                    |  6 +++---
>  configs/colibri_t30_defconfig                    |  6 +++---
>  configs/colibri_vf_defconfig                     |  6 +++---
>  configs/corvus_defconfig                         |  6 +++---
>  configs/dalmore_defconfig                        |  6 +++---
>  configs/dms-ba16-1g_defconfig                    |  6 +++---
>  configs/dms-ba16_defconfig                       |  6 +++---
>  configs/dra7xx_evm_defconfig                     |  6 +++---
>  configs/dra7xx_hs_evm_defconfig                  |  6 +++---
>  configs/draco_defconfig                          |  6 +++---
>  configs/e2220-1170_defconfig                     |  6 +++---
>  configs/edison_defconfig                         |  6 +++---
>  configs/etamin_defconfig                         |  6 +++---
>  configs/evb-rk3036_defconfig                     |  6 +++---
>  configs/evb-rk3229_defconfig                     |  6 +++---
>  configs/evb-rk3288_defconfig                     |  6 +++---
>  configs/evb-rk3328_defconfig                     |  6 +++---
>  configs/fennec-rk3288_defconfig                  |  6 +++---
>  configs/firefly-rk3288_defconfig                 |  6 +++---
>  configs/gwventana_emmc_defconfig                 |  6 +++---
>  configs/gwventana_gw5904_defconfig               |  6 +++---
>  configs/gwventana_nand_defconfig                 |  6 +++---
>  configs/jetson-tk1_defconfig                     |  6 +++---
>  configs/kc1_defconfig                            |  6 +++---
>  configs/kylin-rk3036_defconfig                   |  6 +++---
>  configs/ma5d4evk_defconfig                       |  6 +++---
>  configs/miqi-rk3288_defconfig                    |  6 +++---
>  configs/mx6qsabrelite_defconfig                  |  6 +++---
>  configs/mx6sabreauto_defconfig                   |  6 +++---
>  configs/mx6sabresd_defconfig                     |  6 +++---
>  configs/mx7dsabresd_defconfig                    |  6 +++---
>  configs/mx7dsabresd_secure_defconfig             |  6 +++---
>  configs/nitrogen6dl2g_defconfig                  |  6 +++---
>  configs/nitrogen6dl_defconfig                    |  6 +++---
>  configs/nitrogen6q2g_defconfig                   |  6 +++---
>  configs/nitrogen6q_defconfig                     |  6 +++---
>  configs/nitrogen6s1g_defconfig                   |  6 +++---
>  configs/nitrogen6s_defconfig                     |  6 +++---
>  configs/nyan-big_defconfig                       |  6 +++---
>  configs/odroid-xu3_defconfig                     |  6 +++---
>  configs/odroid_defconfig                         |  6 +++---
>  configs/omap3_beagle_defconfig                   |  6 +++---
>  configs/omap3_evm_defconfig                      |  6 +++---
>  configs/omap3_logic_defconfig                    |  6 +++---
>  configs/omap5_uevm_defconfig                     |  6 +++---
>  configs/opos6uldev_defconfig                     |  6 +++---
>  configs/origen_defconfig                         |  6 +++---
>  configs/p2371-0000_defconfig                     |  6 +++---
>  configs/p2371-2180_defconfig                     |  6 +++---
>  configs/p2571_defconfig                          |  6 +++---
>  configs/parrot_r16_defconfig                     |  6 +++---
>  configs/phycore-rk3288_defconfig                 |  6 +++---
>  configs/pico-imx6ul_defconfig                    |  6 +++---
>  configs/pico-imx7d_defconfig                     |  6 +++---
>  configs/popmetal-rk3288_defconfig                |  6 +++---
>  configs/pxm2_defconfig                           |  6 +++---
>  configs/rastaban_defconfig                       |  6 +++---
>  configs/rock2_defconfig                          |  6 +++---
>  configs/rut_defconfig                            |  6 +++---
>  configs/s5p_goni_defconfig                       |  6 +++---
>  configs/s5pc210_universal_defconfig              |  6 +++---
>  configs/smartweb_defconfig                       |  6 +++---
>  configs/sniper_defconfig                         |  6 +++---
>  configs/socfpga_arria5_defconfig                 |  6 +++---
>  configs/socfpga_cyclone5_defconfig               |  6 +++---
>  configs/socfpga_de0_nano_soc_defconfig           |  6 +++---
>  configs/socfpga_de10_nano_defconfig              |  6 +++---
>  configs/socfpga_mcvevk_defconfig                 |  6 +++---
>  configs/socfpga_sockit_defconfig                 |  6 +++---
>  configs/socfpga_socrates_defconfig               |  6 +++---
>  configs/socfpga_vining_fpga_defconfig            |  6 +++---
>  configs/taurus_defconfig                         |  6 +++---
>  configs/tbs2910_defconfig                        |  6 +++---
>  configs/thuban_defconfig                         |  6 +++---
>  configs/tinker-rk3288_defconfig                  |  6 +++---
>  configs/topic_miami_defconfig                    |  6 +++---
>  configs/topic_miamilite_defconfig                |  6 +++---
>  configs/topic_miamiplus_defconfig                |  6 +++---
>  configs/trats2_defconfig                         |  6 +++---
>  configs/trats_defconfig                          |  6 +++---
>  configs/venice2_defconfig                        |  6 +++---
>  configs/warp7_defconfig                          |  6 +++---
>  configs/warp7_secure_defconfig                   |  6 +++---
>  configs/warp_defconfig                           |  6 +++---
>  configs/xilinx_zynqmp_ep_defconfig               |  6 +++---
>  configs/xilinx_zynqmp_zc1751_xm015_dc1_defconfig |  6 +++---
>  configs/xilinx_zynqmp_zc1751_xm016_dc2_defconfig |  6 +++---
>  configs/xilinx_zynqmp_zcu102_revA_defconfig      |  6 +++---
>  configs/xilinx_zynqmp_zcu102_revB_defconfig      |  6 +++---
>  configs/zynq_microzed_defconfig                  |  6 +++---
>  configs/zynq_picozed_defconfig                   |  6 +++---
>  configs/zynq_z_turn_defconfig                    |  6 +++---
>  configs/zynq_zc702_defconfig                     |  6 +++---
>  configs/zynq_zc706_defconfig                     |  6 +++---
>  configs/zynq_zed_defconfig                       |  6 +++---
>  configs/zynq_zybo_defconfig                      |  6 +++---
>  doc/README.android-fastboot                      |  8 ++++----
>  drivers/usb/gadget/Kconfig                       | 18 ++++++++---------
>  drivers/usb/gadget/g_dnl.c                       | 12 +++++------
>  include/configs/am43xx_evm.h                     |  6 +++---
>  include/configs/odroid_xu3.h                     |  2 +-
>  149 files changed, 453 insertions(+), 453 deletions(-)

Reviewed-by: Simon Glass <sjg at chromium.org>

But please add help for the new Kconfig options - these are the
product/vendor IDs reported to the host by U-Boot when it is acting as
a device, right? I think that should be mentioned including how to
chose a suitable value.

Regards,
Simon


More information about the U-Boot mailing list