[U-Boot] [PATCH 04/13] usb: gadget: usb_ether: Move the interfaces to Kconfig

Simon Glass sjg at chromium.org
Tue Sep 12 12:28:03 UTC 2017


Hi Maxime,

On 8 September 2017 at 11:34, Maxime Ripard
<maxime.ripard at free-electrons.com> wrote:
> We need to select an interface for the usb_ether gadget, and they haven't
> been converted to Kconfig yet. Add a choice to make sure we have an option
> selected, and convert all the users.
>
> Signed-off-by: Maxime Ripard <maxime.ripard at free-electrons.com>
> ---
>  configs/gwventana_emmc_defconfig       |  1 +
>  configs/gwventana_gw5904_defconfig     |  1 +
>  configs/gwventana_nand_defconfig       |  1 +
>  configs/mx6qsabrelite_defconfig        |  1 +
>  configs/nitrogen6dl2g_defconfig        |  1 +
>  configs/nitrogen6dl_defconfig          |  1 +
>  configs/nitrogen6q2g_defconfig         |  1 +
>  configs/nitrogen6q_defconfig           |  1 +
>  configs/nitrogen6s1g_defconfig         |  1 +
>  configs/nitrogen6s_defconfig           |  1 +
>  configs/novena_defconfig               |  1 +
>  configs/sansa_fuze_plus_defconfig      |  1 +
>  configs/warp7_defconfig                |  1 +
>  configs/warp7_secure_defconfig         |  1 +
>  configs/xfi3_defconfig                 |  1 +
>  drivers/usb/gadget/Kconfig             | 12 ++++++++++++
>  include/configs/am335x_evm.h           |  4 ----
>  include/configs/am3517_evm.h           |  4 ----
>  include/configs/baltos.h               |  4 ----
>  include/configs/gw_ventana.h           |  1 -
>  include/configs/ma5d4evk.h             |  1 -
>  include/configs/nitrogen6x.h           |  1 -
>  include/configs/novena.h               |  1 -
>  include/configs/pcm051.h               |  4 ----
>  include/configs/sama5d2_ptc.h          |  1 -
>  include/configs/sansa_fuze_plus.h      |  1 -
>  include/configs/siemens-am33x-common.h |  4 ----
>  include/configs/vinco.h                |  1 -
>  include/configs/warp7.h                |  2 --
>  include/configs/xfi3.h                 |  1 -
>  scripts/config_whitelist.txt           |  2 --
>  31 files changed, 27 insertions(+), 32 deletions(-)

[..]

> diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
> index 4f29beba1c52..878495fd5d03 100644
> --- a/drivers/usb/gadget/Kconfig
> +++ b/drivers/usb/gadget/Kconfig
> @@ -129,6 +129,18 @@ config USB_ETHER
>
>  if USB_ETHER
>
> +choice
> +       prompt "USB Ethernet Gadget Model"
> +       default USB_ETH_RNDIS
> +
> +config USB_ETH_CDC
> +       bool "CDC-Ethernet model"
> +
> +config USB_ETH_RNDIS
> +       bool "RNDIS model"
> +
> +endchoice
> +

Please add help for these including spelling out the acronyms.

- Simon


More information about the U-Boot mailing list