[U-Boot] [PATCH v3 2/9] fs/fat: introduce new director iterators

Simon Glass sjg at chromium.org
Tue Sep 12 12:29:45 UTC 2017


On 10 September 2017 at 05:21, Rob Clark <robdclark at gmail.com> wrote:
> Untangle directory traversal into a simple iterator, to replace the
> existing multi-purpose do_fat_read_at() + get_dentfromdir().
>
> Signed-off-by: Rob Clark <robdclark at gmail.com>
> Reviewed-by: Ɓukasz Majewski <lukma at denx.de>
> ---
>  fs/fat/fat.c  | 356 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
>  include/fat.h |   7 ++
>  2 files changed, 360 insertions(+), 3 deletions(-)

Reviewed-by: Simon Glass <sjg at chromium.org>

But I still think that fat_itr should not be a typedef, since this is
something you are adding. I understand what you are saying about the
existing code, but really that should be converted at some point, as
you say.


More information about the U-Boot mailing list