[U-Boot] [PATCH 4/8] clk: rockchip: Add Saradc clock support for rk3288
David.Wu
david.wu at rock-chips.com
Wed Sep 13 11:01:29 UTC 2017
Spam detection software, running on the system "lists.denx.de",
has identified this incoming email as possible spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
@@CONTACT_ADDRESS@@ for details.
Content preview: Hi Dr.Philipp å¨ 2017/9/13 18:24, Dr. Philipp Tomsich åé:
> >> On 13 Sep 2017, at 12:09, David Wu <david.wu at rock-chips.com> wrote:
>> > > Please add a commit message. > >> Signed-off-by: David Wu <david.wu at rock-chips.com>
> > Reviewed-by: Philipp Tomsich <philipp.tomsich at theobroma-systems.com>
> > See above and below for requested changes. > >> --- >> drivers/clk/rockchip/clk_rk3288.c
| 45 +++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 45 insertions(+)
>> >> diff --git a/drivers/clk/rockchip/clk_rk3288.c b/drivers/clk/rockchip/clk_rk3288.c
>> index 478195b..29652b0 100644 >> --- a/drivers/clk/rockchip/clk_rk3288.c
>> +++ b/drivers/clk/rockchip/clk_rk3288.c >> @@ -111,6 +111,15 @@ enum {
>> PERI_ACLK_DIV_SHIFT = 0, >> PERI_ACLK_DIV_MASK = 0x1f << PERI_ACLK_DIV_SHIFT,
>> >> + /* >> + * CLKSEL24 >> + * saradc_div_con: >> + * clk_saradc=24MHz/(saradc_div_con+1)
>> + */ >> + CLK_SARADC_DIV_CON_SHIFT = 8, >> + CLK_SARADC_DIV_CON_MASK =
0xff << CLK_SARADC_DIV_CON_SHIFT, >> + CLK_SARADC_DIV_CON_WIDTH = 8, >> +
>> SOCSTS_DPLL_LOCK = 1 << 5, >> SOCSTS_APLL_LOCK = 1 << 6, >> SOCSTS_CPLL_LOCK
= 1 << 7, >> @@ -131,6 +140,11 @@ static const struct pll_div apll_init_cfg
= PLL_DIVISORS(APLL_HZ, 1, 1); >> static const struct pll_div gpll_init_cfg
= PLL_DIVISORS(GPLL_HZ, 2, 2); >> static const struct pll_div cpll_init_cfg
= PLL_DIVISORS(CPLL_HZ, 1, 2); >> >> +static inline u32 extract_bits(u32
val, unsigned width, unsigned shift) >> +{ >> + return (val >> shift) & ((1
<< width) - 1); >> +} > > Please reuse whatâs already available in include/bitfield.h.
> This also applies to all call-sites for extract_bits below: they should
directly use the already existing function. [...]
Content analysis details: (5.6 points, 5.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
0.6 RCVD_IN_SORBS_WEB RBL: SORBS: sender is an abusable web server
[58.22.7.114 listed in dnsbl.sorbs.net]
0.0 KHOP_BIG_TO_CC Sent to 10+ recipients instaed of Bcc or a list
2.6 RCVD_IN_SBL RBL: Received via a relay in Spamhaus SBL
[211.157.147.132 listed in zen.spamhaus.org]
2.4 RCVD_IN_MSPIKE_L5 RBL: Very bad reputation (-5)
[211.157.147.132 listed in bl.mailspike.net]
0.0 RCVD_IN_MSPIKE_BL Mailspike blacklisted
-------------- next part --------------
An embedded message was scrubbed...
From: "David.Wu" <david.wu at rock-chips.com>
Subject: Re: [PATCH 4/8] clk: rockchip: Add Saradc clock support for rk3288
Date: Wed, 13 Sep 2017 19:01:29 +0800
Size: 5453
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170913/73f084b1/attachment.mht>
More information about the U-Boot
mailing list