[U-Boot] lib: disable hashtable and display options code in SPL

Tom Rini trini at konsulko.com
Thu Sep 14 14:47:44 UTC 2017


On Mon, Aug 28, 2017 at 05:53:08PM +0200, Anatolij Gustschin wrote:

> We do not need hashtable code in SPL when building
> without environment support. Also display options
> code is not used in current SPL configuration and
> can be disabled.
> 
> Signed-off-by: Anatolij Gustschin <agust at denx.de>
> ---
>  lib/Makefile | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)

This and https://patchwork.ozlabs.org/patch/806646/ don't give you what
you want I think.  First, take a look at
https://gist.github.com/trini/fb85b11f6337ea9d5d65736762c678ac as these
patches break a number of platforms (there are SPL cases where we do
need these).  And with gcc-6.x and later (which is being required with
v2018.01, which is really soon now), we finally have strings discarded
along with functions, so there's no size savings being seen in almost
every case (it would be interesting to see what the savings is in
Cyprus* and those few arm cases where we do save a tiny bit of text).

In sum, I don't think we want either of these patches, even with the
link errors fixed unless you can show some size savings with gcc-6 or
later.  But those cases in the above gist were size is reduced could
hint at places to look for a different set of changes to make here,
perhaps.  Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170914/12bacbd9/attachment.sig>


More information about the U-Boot mailing list