[U-Boot] [PATCH] Kconfig: BOOTCOMMAND: Define default set of boot commands in Kconfig

[Tom Rini]

On Mon, Sep 11, 2017 at 10:53:51PM +0200, Łukasz Majewski wrote:
> On 09/11/2017 07:31 PM, Tom Rini wrote:
> >On Sun, Sep 10, 2017 at 08:25:02PM +0200, Lukasz Majewski wrote:
> >
> >>This patch gives an opportunity to override the defined CONFIG_BOOTCOMMAND
> >>(at <board_config.h> files) with set of commands defined in
> >>board _defconfig file.
> >>
> >>Rationale: This change allows having two different u-boot builds - one for
> >>production and one (far more larger) for factory setup.
> >>
> >>Signed-off-by: Lukasz Majewski <lukma at denx.de>
> >
> >I don't get it, sorry.  We need to move CONFIG_BOOTCOMMAND into Kconfig
> >with some other logic so that distro_bootcmd stuff works.
> >
> 
> The state of the art:
> ---------------------
> 
> Many boards use CONFIG_BOOTCOMMAND as a set of commands to be
> executed at boot time:
> 
> bootcmd=CONFIG_BOOTCOMMAND
> 
> One notable user of it is config_distro_bootcmd.h

Right.

> Rationale:
> ----------
> 
> With this patch I can:
> 
> 1. Setup one set of commands to be executed by default - e.g.:
> 
> bootcmd="run boot_mmc"
> 
> and
> 
> 2. Have other defconfig - e.g. <my_board>_factory_defconfig, which
> enables some extra stuff (like USB, gadget, gpt write, etc) and is
> used solely for factory flashing.
> 
> By having the opportunity to override CONFIG_BOOTCOMMAND in Kconfig,
> I can use the same code base and just adjust Kconfig for board.
> 
> 
> What do you mean by "some other logic"?

Well, CONFIG_BOOTCOMMAND needs to be moved to Kconfig itself.  Figuring
out some of the "how" will take a little work.  And a little
re-organization.  But that needs doing.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170914/f9dd24b5/attachment.sig>