[U-Boot] [U-Boot, 6/8] clk: rockchip: Add rk3368 Saradc clock support

Dr. Philipp Tomsich philipp.tomsich at theobroma-systems.com
Thu Sep 14 14:55:25 UTC 2017


> On 14 Sep 2017, at 13:17, David.Wu <david.wu at rock-chips.com> wrote:
> 
> Hi Philipp,
> 
> 在 2017/9/14 4:41, Philipp Tomsich 写道:
>>> +static ulong rk3368_saradc_get_clk(struct rk3368_cru *cru)
>>> +{
>>> +    u32 div, val;
>>> +
>>> +    val = readl(&cru->clksel_con[25]);
>>> +    div = bitfield_extract(val, CLK_SARADC_DIV_CON_SHIFT,
>>> +                   CLK_SARADC_DIV_CON_WIDTH);
>> Please reuse the functions from bitfield.h.
> 
> Ah, the bitfield_extract function is from bitfield.h here.
> 

I was suffering from a lack of sleep yesterday, so just ignore this comment of mine.
—Phil.


More information about the U-Boot mailing list