[U-Boot] [PATCH 04/15] spl: fit: simplify logic for FDT loading for non-OS boots

[York Sun]

On 09/13/2017 03:11 PM, Dr. Philipp Tomsich wrote:
> York,
> 
>> On 13 Sep 2017, at 23:24, York Sun <york.sun at nxp.com> wrote:
>>
>> On 09/13/2017 02:21 PM, Dr. Philipp Tomsich wrote:
>>> York,
>>>
>>>> On 13 Sep 2017, at 23:16, York Sun <york.sun at nxp.com> wrote:
>>>>
>>>> On 09/13/2017 12:30 PM, Philipp Tomsich wrote:
>>>>> To better support bootin through an ATF or OPTEE, we need to
>>>>> streamline some of the logic for when the FDT is appended to an image:
>>>>> depending on the image type, we'd like to append the FDT not at all
>>>>> (the case for the OS boot), to the 'firmware' image (if it is a
>>>>> U-Boot) or to one of the loadables (if the 'firmware' is an ATF, an
>>>>> OPTEE, or some other image-type and U-Boot is listed in the
>>>>> loadabled).
>>>>>
>>>>> To achieve this goal, we drop the os_boot flag and track the type of
>>>>> image loaded.  If it is of type IH_OS_U_BOOT, we append the FDT.
>>>>>
>>>>> Signed-off-by: Philipp Tomsich <philipp.tomsich at theobroma-systems.com>
>>>>> ---
>>>>>
>>>>>   common/spl/spl_fit.c | 86 ++++++++++++++++++++++++++++++++++------------------
>>>>>   1 file changed, 56 insertions(+), 30 deletions(-)
>>>>
>>>> This change seems OK. Make sure you test booting OS. Let me know if you
>>>> need help.
>>>
>>> I’d appreciate if you could test this on your end as well. I currently only
>>> have test setups that need to go through ATF before entering an OS (as
>>> the PSCI implementation lives in ATF).
>>
>> Philipp,
>>
>> I can test _this_ patch on my board. Looks like it doesn't depend on
>> other patches.
> 
> The other patches shouldn’t interfere (and have been exercised quite
> a bit on our end): I am only worried about possibly breaking some of
> your changes for your scenario.
> 

Acked-by: York Sun <york.sun at nxp.com>