[U-Boot] [PATCH v2 0/3] support enter download mode on rockchip platform

[Dr. Philipp Tomsich]

Andy,

> On 15 Sep 2017, at 15:23, Andy Yan <andyshrk at gmail.com> wrote:
> 
> Hi Philipp:
> 
> 2017-09-15 20:07 GMT+08:00 Dr. Philipp Tomsich <philipp.tomsich at theobroma-systems.com <mailto:philipp.tomsich at theobroma-systems.com>>:
> Andy,
> 
> > On 14 Sep 2017, at 10:51, Andy Yan <andy.yan at rock-chips.com <mailto:andy.yan at rock-chips.com>> wrote:
> >
> >
> > Most rockchip platform based boards use a key to instruct
> > the board enter download firmware mode, some boards use a
> > adc to detect the key status, and some use a gpio.
> 
> I just sent out a series that updates the back-to-bootrom to be
> written entirely as C-code.
> 
> I’d appreciate if you could review and also modify your changes
> to apply cleanly on top of that one (e.g. save_boot_params.S is
> gone, so you will be able to add your call to check for the download
> key in bootrom.c).
>  
> 
> Thanks very much for the excellent work, I just need a little time to understand - review and test your patch on more platforms.
> And I will send a new version on the top of your patch next Monday.

Take your time: I’d rather have this fully tested and merge it a week (or
even a few weeks) later to allow for the testing.

If there’s a problem with my series, let me know and I’ll take another look. 

> 
> The plan would be to apply first the “rewrite in C” changes and
> then your “download mode” changes on-top.
> If possible, I’d like to get this into next week’s changes and put a
> PR with both out by the end of next week…
> 
> Regards,
> Philipp.
> 
> >
> > This series try to implement all the download mode related
> > functions.
> >
> > Changes in v2:
> > - correct the rk322x boot mode register address
> > - make the help text more clear
> > - implement the back to bootrom download mode check in c, thanks for Dr. Philipp Tomsich's suggestion.
> > - more document
> > - move adc key detect as the defaut
> >
> > Andy Yan (3):
> >  rockchip: make boot_mode related codes reused across all platforms
> >  rockchip: add support for enter to bootrom download mode
> >  rockchip: check download key before bootup
> >
> > arch/arm/include/asm/arch-rockchip/boot_mode.h |  7 +++
> > arch/arm/include/asm/arch-rockchip/bootrom.h   | 15 ++++-
> > arch/arm/mach-rockchip/Kconfig                 | 15 +++++
> > arch/arm/mach-rockchip/Makefile                |  4 ++
> > arch/arm/mach-rockchip/boot_mode.c             | 76 ++++++++++++++++++++++++++
> > arch/arm/mach-rockchip/bootrom.c               | 31 ++++++++++-
> > arch/arm/mach-rockchip/rk3036-board.c          | 24 --------
> > arch/arm/mach-rockchip/rk322x-board.c          | 24 --------
> > arch/arm/mach-rockchip/rk3288-board.c          | 25 ---------
> > arch/arm/mach-rockchip/rk3399-board.c          | 14 +++++
> > arch/arm/mach-rockchip/save_boot_param.S       | 25 ++++++---
> > 11 files changed, 177 insertions(+), 83 deletions(-)
> > create mode 100644 arch/arm/mach-rockchip/boot_mode.c
> > create mode 100644 arch/arm/mach-rockchip/rk3399-board.c
> >
> > --
> > 2.7.4
> >
> >
> 
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de <mailto:U-Boot at lists.denx.de>
> https://lists.denx.de/listinfo/u-boot <https://lists.denx.de/listinfo/u-boot>