[U-Boot] [PATCH please test] fs/fat: reduce stack usage for SPL

Adam Ford aford173 at gmail.com
Sun Sep 17 13:50:43 UTC 2017


On Sun, Sep 17, 2017 at 8:42 AM, Tom Rini <trini at konsulko.com> wrote:
> On Sun, Sep 17, 2017 at 09:38:04AM -0400, Rob Clark wrote:
>
>> It seems like stack usage is a problem for SPL builds.  So move itrblock
>> off the stack.
>>
>> Please test this and see if it helps w/ current issues with SPL builds.
>> Long term, I'm not sure if it is better to do this conditional on SPL
>> builds, or move to malloc()?  At any rate, if this fixes SPL builds it
>> should be a perfectly ok short term solution.
>>
>> Signed-off-by: Rob Clark <robdclark at gmail.com>
>
> Tested-by: Tom Rini <trini at konsulko.com>
>

This fixed the problem on the am3517-evm.  Thank you,

Tested-by: Adam Ford <aford173 at gmail.com>

> Note that malloc would also be fine as we already have a dependency on
> malloc, that's just not (but should be!) expressed in Kconfig, for FAT
> support already.  Thanks!
>
> --
> Tom


More information about the U-Boot mailing list