[U-Boot] [PATCH 01/13] Revert "sandbox: remove os_putc() and os_puts()"

Simon Glass sjg at chromium.org
Sun Sep 17 17:55:42 UTC 2017


Hi Bin,

On 17 September 2017 at 06:48, Bin Meng <bmeng.cn at gmail.com> wrote:
> Hi Simon,
>
> On Sun, Sep 17, 2017 at 5:23 AM, Simon Glass <sjg at chromium.org> wrote:
>> While sandbox works OK without the special-case code, it does result in
>> console output being stored in the pre-console buffer while sandbox starts
>> up. If there is a crash or a problem then there is no indication of what
>> is going on.
>>
>
> I don't understand where the issue is. I built with current
> sandbox_defconfig w/ or w/o CONFIG_PRE_CONSOLE_BUFFER, both work fine.
>

Did you try adding a crash before console_init_f()? The problem is
that any early problems in sandbox are not reported. It just crashes
with no output. With these two patches reverted you can see what is
going on.

>> For ease of debugging it seems better to revert this change.
>>
>> This reverts commit 47b98ad0f6779485d0f0c14f337c3eece273eb54.
>>
>> Signed-off-by: Simon Glass <sjg at chromium.org>
>> ---
>>
>>  arch/sandbox/cpu/os.c | 11 +++++++++++
>>  include/os.h          | 20 ++++++++++++++++++++
>>  2 files changed, 31 insertions(+)
>>

REgards,
Simon


More information about the U-Boot mailing list