[U-Boot] [PATCH] Remove "no previous prototype" warning

Fabio Estevam festevam at gmail.com
Thu Sep 21 16:55:20 UTC 2017


Hi Diego,

On Thu, Sep 21, 2017 at 11:47 AM, Diego Dorta <diego.dorta at nxp.com> wrote:
> When compiling with W=1 the following warning is observed:
>
> board/freescale/mx6sabresd/mx6sabresd.c:266:5: warning:
> no previous prototype for ‘board_mmc_get_env_dev’
> [-Wmissing-prototypes] int board_mmc_get_env_dev(int devno)
>
> Remove this warning by adding the function prototype into mmc.h file.
>
> Signed-off-by: Diego Dorta <diego.dorta at nxp.com>
> ---
>  include/mmc.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/include/mmc.h b/include/mmc.h
> index 010ebe0..3ddfc2d 100644
> --- a/include/mmc.h
> +++ b/include/mmc.h
> @@ -588,6 +588,7 @@ int board_mmc_init(bd_t *bis);
>  int cpu_mmc_init(bd_t *bis);
>  int mmc_get_env_addr(struct mmc *mmc, int copy, u32 *env_addr);
>  int mmc_get_env_dev(void);
> +int board_mmc_get_env_dev(int devno);

Only imx uses this function, so I would recommend adding its prototype in:
arch/arm/include/asm/mach-imx/sys_proto.h

Thanks


More information about the U-Boot mailing list