[U-Boot] [PATCH 5/6] apalis_imx6: Avoid calling setup_display() from SPL code

[Stefano Babic]

Hi Fabio,

On 23/09/2017 04:45, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam at nxp.com>
> 
> There is no need call setup_display() from SPL code, so move it to
> board_init(), which executes only in U-Boot proper.
> 
> Reported-by: Stefano Babic <sbabic at denx.de>
> Signed-off-by: Fabio Estevam <fabio.estevam at nxp.com>
> ---
>  board/toradex/apalis_imx6/apalis_imx6.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/board/toradex/apalis_imx6/apalis_imx6.c b/board/toradex/apalis_imx6/apalis_imx6.c
> index 628a61d..b86dde8 100644
> --- a/board/toradex/apalis_imx6/apalis_imx6.c
> +++ b/board/toradex/apalis_imx6/apalis_imx6.c
> @@ -756,10 +756,6 @@ int board_early_init_f(void)
>  #else
>  	setup_iomux_dce_uart();
>  #endif
> -
> -#if defined(CONFIG_VIDEO_IPUV3)
> -	setup_display();
> -#endif
>  	return 0;
>  }
>  
> @@ -781,6 +777,10 @@ int board_init(void)
>  	setup_i2c(1, CONFIG_SYS_I2C_SPEED, 0x7f, &i2c_pad_info_loc);
>  	setup_i2c(2, CONFIG_SYS_I2C_SPEED, 0x7f, &i2c_pad_info3);
>  
> +#if defined(CONFIG_VIDEO_IPUV3)
> +	setup_display();
> +#endif
> +
>  #ifdef CONFIG_TDX_CMD_IMX_MFGR
>  	(void) pmic_init();
>  #endif
> 

Max has already fixed apalis / colibri, see for example
http://patchwork.ozlabs.org/patch/817053/. I will apply Max's patches
and drop 5/6 from your series. Anyway, thanks for having thought to
these two boards, too.

Regards,
Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================