[U-Boot] [PATCH 6/6] colibri_imx6: Avoid calling setup_display() from SPL code

[Max Krummenacher]

Hi


I tested this together with Anatolij's patch [1] on a Colibri iMX6. Both with the SPL and non SPL config the behaviour of the graphical output is as expected.


Tested-by: Max Krummenacher <max.krummenacher at toradex.com>


Thanks Fabio.


Max


[1] http://patchwork.ozlabs.org/patch/806755

________________________________
Von: Fabio Estevam <festevam at gmail.com>
Gesendet: Samstag, 23. September 2017 04:45:33
An: sbabic at denx.de
Cc: u-boot at lists.denx.de; agust at denx.de; Max Krummenacher; Fabio Estevam
Betreff: [PATCH 6/6] colibri_imx6: Avoid calling setup_display() from SPL code

From: Fabio Estevam <fabio.estevam at nxp.com>

There is no need call setup_display() from SPL code, so move it to
board_init(), which executes only in U-Boot proper.

Reported-by: Stefano Babic <sbabic at denx.de>
Signed-off-by: Fabio Estevam <fabio.estevam at nxp.com>
---
 board/toradex/colibri_imx6/colibri_imx6.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/board/toradex/colibri_imx6/colibri_imx6.c b/board/toradex/colibri_imx6/colibri_imx6.c
index 756e3f3..a2a4214 100644
--- a/board/toradex/colibri_imx6/colibri_imx6.c
+++ b/board/toradex/colibri_imx6/colibri_imx6.c
@@ -630,9 +630,6 @@ int board_early_init_f(void)
                                          ARRAY_SIZE(pwr_intb_pads));
         setup_iomux_uart();

-#if defined(CONFIG_VIDEO_IPUV3)
-       setup_display();
-#endif
         return 0;
 }

@@ -653,6 +650,10 @@ int board_init(void)
         setup_i2c(2, CONFIG_SYS_I2C_SPEED, 0x7f, &i2c_pad_info1);
         setup_i2c(1, CONFIG_SYS_I2C_SPEED, 0x7f, &i2c_pad_info_loc);

+#if defined(CONFIG_VIDEO_IPUV3)
+       setup_display();
+#endif
+
 #ifdef CONFIG_TDX_CMD_IMX_MFGR
         (void) pmic_init();
 #endif
--
2.7.4