[U-Boot] Makefile: Update minimum dtc version to 1.4.3

Marek Vasut marek.vasut at gmail.com
Sun Sep 24 12:07:27 UTC 2017


On 09/24/2017 01:36 PM, Tom Rini wrote:
> On Sun, Sep 24, 2017 at 10:28:18AM +0200, Marek Vasut wrote:
>> On 09/24/2017 05:22 AM, Tom Rini wrote:
>>> On Sat, Sep 23, 2017 at 09:07:02PM -0500, Robert Nelson wrote:
>>>> On Sat, Sep 23, 2017 at 8:49 PM, Bin Meng <bmeng.cn at gmail.com> wrote:
>>>>> Hi Tom,
>>>>>
>>>>> On Sun, Sep 24, 2017 at 12:10 AM, Tom Rini <trini at konsulko.com> wrote:
>>>>>> On Sat, Sep 23, 2017 at 03:04:39PM +0200, Marek Vasut wrote:
>>>>>>> On 09/23/2017 02:56 PM, Tom Rini wrote:
>>>>>>>> On Sat, Sep 23, 2017 at 12:39:44PM +0200, Marek Vasut wrote:
>>>>>>>>> On 09/22/2017 04:20 PM, Tom Rini wrote:
>>>>>>>>>> On Fri, Sep 15, 2017 at 01:15:25PM -0400, Tom Rini wrote:
>>>>>>>>>>
>>>>>>>>>>> With support for overlays and calling the -@ flag to dtc we need to have
>>>>>>>>>>> at least 1.4.3 available now.
>>>>>>>>>>>
>>>>>>>>>>> Cc: Simon Glass <sjg at chromium.org>
>>>>>>>>>>> Reported-by: Stephen Warren <swarren at wwwdotorg.org>
>>>>>>>>>>> Signed-off-by: Tom Rini <trini at konsulko.com>
>>>>>>>>>>
>>>>>>>>>> Applied to u-boot/master, thanks!
>>>>>>>>>
>>>>>>>>> Debian still only has 1.4.2 even in unstable, so u-boot/master no longer
>>>>>>>>> builds on any debian system.
>>>>>>>>
>>>>>>>> Then perhaps we need to mirror the kernel and provide / build dtc, but
>>>>>>>> allow for people to override it.
>>>>>>>
>>>>>>> What about allowing old DTC version if DTOs are not in use ?
>>>>>>
>>>>>> If you can re-work the logic for that, sure, thanks!
>>>>>>
>>>>>
>>>>> Ubuntu 16.04 LTS is still at dtc v1.4.0, so it's broken there too.
>>>>
>>>> Maybe it's just time to embed a copy of dtc into u-boot (like the
>>>> kernel, especially since we use so many features...)?
>>>
>>> That is my intention at this point, and I'm testing a small series to do
>>> that now (the last pain point looks to have been the patch that allows
>>> 'DTC' to be over-ridden for FreeBSD).
>>
>> cfr my comment about vendoring , I'd really hate to go down that path.
>> Chrome does that and look what came out of it -- outdated patched
>> packages in the chrome codebase, with debian trying hard to unbundle
>> that stuff again.
> 
> Yes, but we're going to do it all the same.  We're tied to some of the
> tools we need and vendors aren't keeping pace with them either.  dtc
> 1.4.0 (Ubuntu 16.04) is from 2013.  dtc 1.4.3 is from last December.

The new DTC version is only mandated by DTO support, which is not used
by anyone to my knowledge at this point. Whoever wants to use DTO,
should have new enough DTC and I'm fine with the build failing if they
don't.

This heavy-handed approach of imposing custom DTC build on everyone
because of a feature noone uses is awful and I disagree with it. If
there is a version check for DTC for builds with and without DTO, fine,
I can live with that.

But bundling DTC only because of unused functionality, NAK.

> And I plan on following the Linux Kernel model of just syncing only
> directly with the upstream project.

See above, this is heavy-handed and IMO unnecessary. In fact, I hope the
kernel removes the DTC fork completely.

-- 
Best regards,
Marek Vasut


More information about the U-Boot mailing list