[U-Boot] [PATCH v2 5/5] mmc: omap_hsmmc: Fix incorrect bit operations for disabling a bit

Tom Rini trini at konsulko.com
Sun Sep 24 14:40:15 UTC 2017


On Thu, Sep 21, 2017 at 04:51:36PM +0200, Jean-Jacques Hiblot wrote:

> From: Kishon Vijay Abraham I <kishon at ti.com>
> 
> omap_hsmmc driver uses "|" in a couple of places for disabling a bit.
> While it's okay to use it in "mmc_reg_out" (since mmc_reg_out has a
> _mask_ argument to take care of resetting a bit), it's incorrectly used
> for resetting flags in "omap_hsmmc_send_cmd".
> 
> Fix it here by using "&= ~()" to reset a bit.
> 
> Signed-off-by: Kishon Vijay Abraham I <kishon at ti.com>
> Signed-off-by: Jean-Jacques Hiblot <jjhiblot at ti.com>

Reviewed-by: Tom Rini <trini at konsulko.com>

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170924/a4457fda/attachment.sig>


More information about the U-Boot mailing list