[U-Boot] [PATCH 2/3] fs/fat: Fix pathnames using '..' that lead to the root directory

Tuomas Tynkkynen tuomas.tynkkynen at iki.fi
Sun Sep 24 21:07:35 UTC 2017


If we end up back in the root directory via a '..' directory entry, set
itr->is_root accordingly. Failing to do that gives spews like
"Invalid FAT entry" and being unable to access directory entries located
past the first cluster of the root directory on FAT12/FAT16.

Fixes: 8eafae209c35 ("fat/fs: convert to directory iterators")
Signed-off-by: Tuomas Tynkkynen <tuomas.tynkkynen at iki.fi>
---
 fs/fat/fat.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/fs/fat/fat.c b/fs/fat/fat.c
index 36a309c73c..3d3e17e8fa 100644
--- a/fs/fat/fat.c
+++ b/fs/fat/fat.c
@@ -710,13 +710,14 @@ static void fat_itr_child(fat_itr *itr, fat_itr *parent)
 	itr->fsdata = parent->fsdata;
 	if (clustnum > 0) {
 		itr->clust = clustnum;
+		itr->is_root = 0;
 	} else {
 		itr->clust = parent->fsdata->root_cluster;
+		itr->is_root = 1;
 	}
 	itr->dent = NULL;
 	itr->remaining = 0;
 	itr->last_cluster = 0;
-	itr->is_root = 0;
 }
 
 static void *next_cluster(fat_itr *itr)
-- 
2.13.0



More information about the U-Boot mailing list