[U-Boot] [PATCH 1/1] efi_loader: provide function comments for boot services

Simon Glass sjg at chromium.org
Mon Sep 25 02:14:09 UTC 2017


On 21 September 2017 at 10:30, Heinrich Schuchardt <xypron.glpk at gmx.de> wrote:
> Provide comments describing the boot service functions.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
> ---
>  lib/efi_loader/efi_boottime.c | 640 +++++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 638 insertions(+), 2 deletions(-)

Great to see this - but please can you put these comments in the
header file? That's the file that people read to see the API.

nit: efi_locate_protocol() needs a @return


More information about the U-Boot mailing list