[U-Boot] [PATCH] fs/ext4/ext4fs.c: Free dirnode in error path of ext4fs_ls

Tom Rini trini at konsulko.com
Wed Sep 27 02:43:45 UTC 2017


As reported by Coverity, we did not free dirnode in the case of failure.
Do so now.

Reported-by: Coverity (CID: 131221)
Cc: Stefan BrĂ¼ns <stefan.bruens at rwth-aachen.de>
Signed-off-by: Tom Rini <trini at konsulko.com>
---
 fs/ext4/ext4fs.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/ext4/ext4fs.c b/fs/ext4/ext4fs.c
index 081509dbb4db..b0c7303aa410 100644
--- a/fs/ext4/ext4fs.c
+++ b/fs/ext4/ext4fs.c
@@ -167,6 +167,7 @@ int ext4fs_ls(const char *dirname)
 				  FILETYPE_DIRECTORY);
 	if (status != 1) {
 		printf("** Can not find directory. **\n");
+		ext4fs_free_node(dirnode, &ext4fs_root->diropen);
 		return 1;
 	}
 
-- 
1.9.1



More information about the U-Boot mailing list