[U-Boot] [U-Boot, 1/1] GPT: incomplete initialization in allocate_disk_part

Tom Rini trini at konsulko.com
Wed Sep 27 02:45:49 UTC 2017


On Thu, Sep 21, 2017 at 07:03:06PM +0200, Heinrich Schuchardt wrote:

> memset(newpart, '\0', sizeof(newpart));
> only initializes the firest 4 or 8 bytes of *newpart and not the whole
> structure disk_part.
> 
> We should use sizeof(struct disk_part).
> 
> Instead of malloc and memset we can use calloc.
> 
> Identified by cppcheck.
> 
> Fixes: 09a49930e41 GPT: read partition table from device into a data structure
> Reported-by: Coverity (CID: 167228)
> Cc: Stefan Roese <sr at denx.de>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
> Reviewed-by: Stefan Roese <sr at denx.de>
> Reviewed-by: Simon Glass <sjg at chromium.org>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170926/bb5baed6/attachment.sig>


More information about the U-Boot mailing list