[U-Boot] [PATCH] Revert "sunxi: imply USB_GADGET"

Maxime Ripard maxime.ripard at free-electrons.com
Fri Sep 29 12:54:56 UTC 2017


On Fri, Sep 29, 2017 at 11:44:48AM +0000, Icenowy Zheng wrote:
> This reverts commit 061221ae61440eb05fd5b94ca77c7731315cbddd.
> 
> The implying of USB_GADGET makes the boards without USB_MUSB_GADGET
> enabled not able to be built in the U-Boot, and the number of the
> boards broken is much more than the boards benefited from this
> commit. So it's reverted.
> 
> Signed-off-by: Icenowy Zheng <icenowy at aosc.io>
> ---
>  arch/arm/Kconfig                               | 1 -
>  configs/A13-OLinuXino_defconfig                | 2 ++
>  configs/A20-OLinuXino-Lime2-eMMC_defconfig     | 2 ++
>  configs/A20-OLinuXino-Lime2_defconfig          | 2 ++
>  configs/CHIP_defconfig                         | 2 ++
>  configs/CHIP_pro_defconfig                     | 2 ++
>  configs/Cubietruck_defconfig                   | 2 ++
>  configs/Nintendo_NES_Classic_Edition_defconfig | 2 ++
>  configs/Sinlinx_SinA33_defconfig               | 2 ++
>  configs/parrot_r16_defconfig                   | 2 ++
>  10 files changed, 18 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index 28b30ce0c3..e78a43a519 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -704,7 +704,6 @@ config ARCH_SUNXI
>  	imply SPL_MMC_SUPPORT if MMC
>  	imply SPL_POWER_SUPPORT
>  	imply SPL_SERIAL_SUPPORT
> -	imply USB_GADGET

This doesn't fix anything though. You still have the option to enable
that option in the offended boards, and it will be just as broken.

What is the breakage you have, on what boards?

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170929/395dd03e/attachment.sig>


More information about the U-Boot mailing list