[U-Boot] [PATCH 1/4] dm: gpio: vybrid_gpio: Correct driver's use of bind() method

sjg at google.com sjg at google.com
Fri Sep 29 21:00:35 UTC 2017


It does not look like this driver needs to use a bind() method. It does
not manually create devices with device_bind() nor does it create devices
using U_BOOT_DEVICE(). It seems to only use device tree.

Therefore the manual allocation of platform data is not needed and is
confusing. Also platform data should be set up by the ofdata_to_platdata()
method, not bind().

Update the driver in case others use it as a model in future.

Signed-off-by: Simon Glass <sjg at chromium.org>
Reported-by: Adam Ford <aford173 at gmail.com>
---

 drivers/gpio/vybrid_gpio.c | 25 ++++++-------------------
 1 file changed, 6 insertions(+), 19 deletions(-)

Applied to u-boot-dm thanks!


More information about the U-Boot mailing list