[U-Boot] fsl_esdhc driver is broken with DM

Fabio Estevam festevam at gmail.com
Sat Sep 30 15:35:22 UTC 2017


Hi,

I noticed that  fsl_esdhc is broken on 2017.09 for mx6slevk, when
CONFIG_DM_MMC is selected:

U-Boot 2017.09 (Sep 30 2017 - 12:31:17 -0300)

CPU:   Freescale i.MX6SL rev1.0 792 MHz (running at 396 MHz)
CPU:   Commercial temperature grade (0C to 95C) at 35C
Reset cause: WDOG
Model: Freescale i.MX6 SoloLite EVK Board
Board: MX6SLEVK
DRAM:  1 GiB
PMIC: PFUZE100! DEV_ID=0x10 REV_ID=0x11
MMC:
MMC Device 1 not found
*** Warning - No MMC card found, using default environment

In:    serial
Out:   serial
Err:   serial
Net:   FEC
Hit any key to stop autoboot:  0
=> mmc info
No MMC device available
=>

2017.07 works fine.

I ran a bisect which pointed to:

commit d6eb25e9878617f9a1d7f06ec21c9b981bb0a4e5
Author: Simon Glass <sjg at chromium.org>
Date:   Sat Jul 29 11:35:22 2017 -0600

    dm: mmc: fsl_esdhc: Drop mmc_init() call from fsl_esdhc_init()

    We want to use fsl_esdhc_init() with driver model. Move the mmc_init() out
    of this function so that we can use it for our common init.

    Signed-off-by: Simon Glass <sjg at chromium.org>

If I remove CONFIG_DM_MMC:

--- a/configs/mx6slevk_defconfig
+++ b/configs/mx6slevk_defconfig
@@ -31,7 +31,6 @@ CONFIG_DM=y
 # CONFIG_BLK is not set
 CONFIG_DM_GPIO=y
 CONFIG_DM_I2C=y
-CONFIG_DM_MMC=y
 CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_STMICRO=y
 CONFIG_PHYLIB=y

Then the mmc can be used normally.

Any ideas on how to fix this properly so that fsl_esdhc can work with DM?

Thanks


More information about the U-Boot mailing list