[U-Boot] [PATCH v2 2/3] dm: led: auto probe() LEDs with "default-state"

[Patrick Brünn]

>From: sjg at google.com [mailto:sjg at google.com] On Behalf Of Simon Glass
>Sent: Dienstag, 3. April 2018 19:53
>To: linux-kernel-dev <linux-kernel-dev at beckhoff.com>
>Cc: U-Boot Mailing List <u-boot at lists.denx.de>; Patrick Brünn
><P.Bruenn at beckhoff.com>; Ziping Chen <techping.chan at gmail.com>
>Subject: Re: [PATCH v2 2/3] dm: led: auto probe() LEDs with "default-state"
>
>On 3 April 2018 at 15:31,  <linux-kernel-dev at beckhoff.com> wrote:
>> From: Patrick Bruenn <p.bruenn at beckhoff.com>
>>
...
>>
>> diff --git a/drivers/led/led_gpio.c b/drivers/led/led_gpio.c
>> index e68d8d3864..d2fe3d5ad5 100644
>> --- a/drivers/led/led_gpio.c
>> +++ b/drivers/led/led_gpio.c
>> @@ -11,6 +11,7 @@
>>  #include <led.h>
>>  #include <asm/gpio.h>
>>  #include <dm/lists.h>
>> +#include <dm/uclass-internal.h>
>>
>>  DECLARE_GLOBAL_DATA_PTR;
>>
>> @@ -120,6 +121,14 @@ static int led_gpio_bind(struct udevice *parent)
>>                         return ret;
>>                 uc_plat = dev_get_uclass_platdata(dev);
>>                 uc_plat->label = label;
>> +
>> +               if (ofnode_read_string(node, "default-state")) {
>
>Here I think you mean ofnode_read_boot() ?
>
Yes, you are right I will resend a v3 with ofnode_read_bool().

It took me quite a while to understand that "read_bool" means "has_property".

Thanks for your help!
Patrick
Beckhoff Automation GmbH & Co. KG | Managing Director: Dipl. Phys. Hans Beckhoff
Registered office: Verl, Germany | Register court: Guetersloh HRA 7075