[U-Boot] [PATCHv2 1/6] reset: socfpga: add reset driver for SoCFPGA platform

[Marek Vasut]

On 04/05/2018 12:18 AM, Dinh Nguyen wrote:
> Add a DM compatible reset driver for the SoCFPGA platform.
> 
> Signed-off-by: Dinh Nguyen <dinguyen at kernel.org>

[...]

> +static int socfpga_reset_request(struct reset_ctl *reset_ctl)
> +{
> +	debug("%s(reset_ctl=%p) (dev=%p, id=%lu)\n", __func__,
> +	      reset_ctl, reset_ctl->dev, reset_ctl->id);
> +
> +	return 0;
> +}
> +
> +static int socfpga_reset_free(struct reset_ctl *reset_ctl)
> +{
> +	debug("%s(reset_ctl=%p) (dev=%p, id=%lu)\n", __func__, reset_ctl,
> +	      reset_ctl->dev, reset_ctl->id);
> +
> +	return 0;
> +}

Is request/free needed at all ? It looks like a useless debug to me.

> +static const struct reset_ops socfpga_reset_ops = {
> +	.request = socfpga_reset_request,
> +	.free = socfpga_reset_free,
> +	.rst_assert = socfpga_reset_assert,
> +	.rst_deassert = socfpga_reset_deassert,
> +};

[...]

-- 
Best regards,
Marek Vasut