[U-Boot] [PATCH v2 1/2] SPI Flash: add support of sst26wf* flash series

[Jagan Teki]

On Thu, Apr 5, 2018 at 6:10 PM, Eugeniy Paltsev
<Eugeniy.Paltsev at synopsys.com> wrote:
> On Wed, 2018-04-04 at 19:58 +0530, Jagan Teki wrote:
>> On Mon, Mar 26, 2018 at 4:38 PM, Eugeniy Paltsev
>> <Eugeniy.Paltsev at synopsys.com> wrote:
>> > sst26wf flash series block protection implementation differs
>> > from other SST series, so add implementation for sst26wf
>> > lock/unlock/is_locked functions.
> [snip]
>> >
>> > +/* sst26wf series block protection implementation differs from other series */
>> > +#if defined(CONFIG_SPI_FLASH_SST)
>> > +       if (JEDEC_MFR(info) == SPI_FLASH_CFI_MFR_SST &&
>> > +           (JEDEC_ID(info) >> 8) == 0x26) {
>>
>> You can directly use JEDEC_ID that may cover id[0], id[1]? or does
>> this only for id[0]?
>
> It is only for "JEDEC Device Type Byte" (byte 1) == 0x26;
> "Device ID Byte" (byte 2) can be any.
>
> But I can write it like
>   (info->id[1] == 0x26)
> instead of
>   ((JEDEC_ID(info) >> 8) == 0x26)

OK.