[U-Boot] [PATCH] sunxi: A64/H5 devices: enable usb keyboard support

Peter Robinson pbrobinson at gmail.com
Mon Apr 9 13:13:00 UTC 2018


On Mon, Apr 9, 2018 at 1:53 PM, Maxime Ripard <maxime.ripard at bootlin.com> wrote:
> On Mon, Apr 09, 2018 at 01:15:00PM +0100, Peter Robinson wrote:
>> Now the A64/H5 SoCs support video output it's useful to enable usb keyboard
>> support so console can be used via standard keyboard/video interface.
>>
>> Tested on Pine64.
>>
>> Signed-off-by: Peter Robinson <pbrobinson at gmail.com>
>
> Don't forget any maintainers when you're sending a patch :)

The list in the cc: is what ./scripts/get_maintainer.pl returned when
run against the patch

>> ---
>>  configs/a64-olinuxino_defconfig       | 2 ++
>>  configs/bananapi_m64_defconfig        | 2 ++
>>  configs/nanopi_a64_defconfig          | 2 ++
>>  configs/nanopi_neo2_defconfig         | 2 ++
>>  configs/nanopi_neo_plus2_defconfig    | 2 ++
>>  configs/orangepi_pc2_defconfig        | 2 ++
>>  configs/orangepi_win_defconfig        | 2 ++
>>  configs/orangepi_zero_plus2_defconfig | 2 ++
>>  configs/pine64_plus_defconfig         | 2 ++
>>  configs/sopine_baseboard_defconfig    | 2 ++
>>  10 files changed, 20 insertions(+)
>>
>> diff --git a/configs/a64-olinuxino_defconfig b/configs/a64-olinuxino_defconfig
>> index 6edefa4f67..c4cdec4771 100644
>> --- a/configs/a64-olinuxino_defconfig
>> +++ b/configs/a64-olinuxino_defconfig
>> @@ -13,3 +13,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-olinuxino"
>>  CONFIG_SUN8I_EMAC=y
>>  CONFIG_USB_EHCI_HCD=y
>>  CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
>> +CONFIG_DM_KEYBOARD=y
>> +CONFIG_USB_KEYBOARD=y
>
> Both are already selected by ARCH_SUNXI if DISTRO_DEFAULTS is set. In
> turn, DISTRO_DEFAULTS is enabled by default if ARCH_SUNXI is. Why do
> you need to enable it in the defconfig?
>
> If this doesn't work for some reason, this should be fixed at the
> Kconfig level, not in the defconfig.
>
> Maxime
>
> --
> Maxime Ripard, Bootlin (formerly Free Electrons)
> Embedded Linux and Kernel engineering
> https://bootlin.com


More information about the U-Boot mailing list