[U-Boot] [U-Boot, v2, 1/5] Migrate CONFIG_DRIVER_TI_CPSW to Kconfig

[Felix Brack]

On 10.04.2018 17:30, Tom Rini wrote:
> On Tue, Apr 10, 2018 at 05:26:25PM +0200, Felix Brack wrote:
>> On 10.04.2018 16:50, Tom Rini wrote:
>>> On Tue, Apr 10, 2018 at 04:11:09PM +0200, Felix Brack wrote:
>>>> On 10.04.2018 15:30, Tom Rini wrote:
>>>>> On Tue, Apr 10, 2018 at 02:59:23PM +0200, Felix Brack wrote:
>>>>>> On 10.04.2018 14:54, Tom Rini wrote:
>>>>>>> On Tue, Apr 10, 2018 at 02:43:47PM +0200, Felix Brack wrote:
>>>>>>>> On 10.04.2018 14:23, Tom Rini wrote:
>>>>>>>>> On Tue, Apr 10, 2018 at 09:21:06AM +0200, Felix Brack wrote:
>>>>>>>>>> Hi Tom,
>>>>>>>>>>
>>>>>>>>>> On 09.04.2018 17:03, Tom Rini wrote:
>>>>>>>>>>> On Sun, Apr 01, 2018 at 09:22:34AM +0000, Alex Kiernan wrote:
>>>>>>>>>>>
>>>>>>>>>>>> This converts CONFIG_DRIVER_TI_CPSW to Kconfig
>>>>>>>>>>>>
>>>>>>>>>>>> Signed-off-by: Alex Kiernan <alex.kiernan at gmail.com>
>>>>>>>>>>>> Acked-by: Joe Hershberger <joe.hershberger at ni.com>
>>>>>>>>>>>
>>>>>>>>>>> Applied to u-boot/master, thanks!
>>>>>>>>>>
>>>>>>>>>> Why did you apply this patch? It introduces a build warning?
>>>>>>>>>
>>>>>>>>> Wait, where does it introduce a warning?  Thanks!
>>>>>>>>>
>>>>>>>> Please see my post from April 2nd on top of this thread in reply to
>>>>>>>> "[PATCH v2 1/5] Migrate CONFIG_DRIVER_TI_CPSW to Kconfig".
>>>>>>>> It is identical to the warning that shows up in the log provide by
>>>>>>>> Alex's link: https://travis-ci.org/akiernan/u-boot/jobs/360830565#L962.
>>>>>>>
>>>>>>> Ahhh.  Doesn't fail travis and I had a local goof-up and missed it in
>>>>>>> my build logs.  Sorry.  Now, you have the CPSW driver enabled, but don't
>>>>>>> want NET?  Or am I misunderstanding?  Thanks!
>>>>>>
>>>>>> Exactly, the board doesn't need NET.
>>>>>
>>>>> But then what are you using the CPSW driver for?
>>>>>
>>>> I don't really understand your question. This patch is from Alex, i.e. I
>>>> am not the author of the patch. I never asked for CPSW driver support
>>>> for the PDU001 board. Here is what I wrote April 2nd:
>>>>
>>>> [quote on]
>>>> Applying this patch series generates the following warning while
>>>> creating the default configuration for board PDU001:
>>>>
>>>> warning: (BOARD_SPECIFIC_OPTIONS && BOARD_SPECIFIC_OPTIONS &&
>>>> BOARD_SPECIFIC_OPTIONS && BOARD_SPECIFIC_OPTIONS && DRIVER_TI_CPSW &&
>>>> AG7XXX && ALTERA_TSE && BCM_SF2_ETH && DWC_ETH_QOS && ETH_DESIGNWARE &&
>>>> MVNETA && MVPP2 && MACB && PCH_GBE && SUN4I_EMAC && SUN8I_EMAC &&
>>>> SH_ETHER && XILINX_AXIEMAC && XILINX_EMACLITE && ZYNQ_GEM && PIC32_ETH
>>>> && RENESAS_RAVB) selects PHYLIB which has unmet direct dependencies (NET)
>>>>
>>>> This is due to the patch enabling CONFIG_DRIVER_TI_CPSW while leaving
>>>> CONFIG_NET disabled.
>>>> This board does not require/have network support for U-Boot so there is
>>>> no need or benefit activating CONFIG_DRIVER_TI_CPSW here. Leaving the
>>>> file configs/am355x_pdu001_defconfig without any modifications will make
>>>> your patch work properly and result in a clean, warning and error free,
>>>> build for the PDU001 board.
>>>> [quote off]
>>>>
>>>> So the solution for the PDU001 board warning problem is _not_ to add NET
>>>> but to remove CPSW. This leaves the file configs/am355x_pdu001_defconfig
>>>> unchanged by this patch and that is what I suggested as solution.
>>>> In other words: the PDU001 board (for now) does not provide any network
>>>> support in U-Boot.
>>>
>>> So, ah-ha-ha! At heart, include/configs/pdu001.h grabs
>>> include/configs/ti_am335x_common.h which was always enabling the CPSW
>>> driver.  So the migration picked that up.  But since you're saying your
>>> platform does not want CPSW, we can just drop that now.  Thanks!
>>>
>> Ah, so you're going to drop configs/am355x_pdu001_defconfig from the
>> patch, correct?
> 
> I'm dropping that hunk out, and a few other small clean-ups
> (am43xx_evm_rtconly is out of sync, and there's a few places with
> non-applicable CPSW comments blocks now).
> 
Okay, sounds good. Please CC me for the modified patch.

many thanks, Felix