[U-Boot] arm: socfpga: unable to boot cyclone5 devkit or SocKit

[Tom Rini]

On Wed, Apr 11, 2018 at 10:12:42AM +0200, Marek Vasut wrote:
> On 04/11/2018 04:52 AM, Dinh Nguyen wrote:
> [...]
> 
> >>>> u-boot$ git reset --hard v2018.01 ; bu socfpga_cyclone5 ; ls -la
> >>>> spl/u-boot-spl.bin
> >>>> HEAD is now at f3dd87e0b9 Prepare v2018.01
> >>>> -rw-r--r-- 1 marex marex 52902 Apr 11 00:34 spl/u-boot-spl.bin
> >>>>
> >>>> u-boot$ git reset --hard v2018.03 ; bu socfpga_cyclone5 ; ls -la
> >>>> spl/u-boot-spl.bin
> >>>> HEAD is now at f95ab1fb6e Prepare v2018.03
> >>>> -rw-r--r-- 1 marex marex 59706 Apr 11 00:34 spl/u-boot-spl.bin
> >>>>
> >>>> Try bisecting out the commit which caused this 7 kiB growth between
> >>>> 2018.01 and 2018.03 . Even those 53 kiB are quite borderline, but it was
> >>>> at 53 kiB for a while (2017.05 is also ~53 kiB)

Do you have a size constraint and are not setting the correct CONFIG
options so that it becomes a build failure?

> >>> Doing the bisect points me to this commit:
> >>>
> >>> commit fa2c14676c7c6f3115dd4d9b2a4cc3b35c3ad2a2
> >>> Author: Tom Rini <trini at konsulko.com>
> >>> Date:   Sat Feb 10 16:54:38 2018 -0500
> >>>
> >>>     configs: Re-sync with CONFIG_DISTRO_DEFAULTS
> >>>
> >>>     A number of platforms include config_distro_defaults.h but do not enable
> >>>     CONFIG_DISTRO_DEFAULTS.  As they plainly intended to, set that flag and
> >>>     re-sync config files.
> >>>
> >>>     Signed-off-by: Tom Rini <trini at konsulko.com>
> >>>
> >>> Doing a revert of the above commit shrinks the SPL back down to ~7 kiB.
> >>>
> >>> Dinh
> >>>
> >>
> >> It looks like the enablement of CONFIG_DISTRO_DEFAULTS, enables these
> >> configs:
> >>
> >> CONFIG_ISO_PARTITION=y
> >> CONFIG_SPL_ISO_PARTITION=y
> >> # CONFIG_AMIGA_PARTITION is not set
> >> # CONFIG_SPL_AMIGA_PARTITION is not set
> >> CONFIG_EFI_PARTITION=y
> >> CONFIG_EFI_PARTITION_ENTRIES_NUMBERS=128
> >> CONFIG_EFI_PARTITION_ENTRIES_OFF=0
> >> CONFIG_SPL_EFI_PARTITION=y
> >> CONFIG_PARTITION_UUIDS=y
> >> CONFIG_SPL_PARTITION_UUIDS=y
> >> # CONFIG_PARTITION_TYPE_GUID is not set
> >>
> >> Which is contributing to the SPL growth.
> >>
> > 
> > Turning the following config options off subtracts 7k from the SPL:
> > 
> > +# CONFIG_SPL_ISO_PARTITION is not set
> > +# CONFIG_SPL_EFI_PARTITION is not set
> > 
> > Not sure if these are needed?
> 
> IMO not on SoCFPGA. Also CCing Tom.

Yes, all of those options are part of CONFIG_DISTRO_DEFAULTS and are
needed so that booting from various distro media works.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180411/3d778fd9/attachment.sig>