[U-Boot] [PATCH v2 10/18] bios: vesa: Guard setting vesa mode with CONFIG_FRAMEBUFFER_SET_VESA_MODE

Bin Meng bmeng.cn at gmail.com
Fri Apr 13 03:30:09 UTC 2018


Hi Simon,

On Fri, Apr 13, 2018 at 12:42 AM, Simon Glass <sjg at chromium.org> wrote:
> Hi Bin,
>
> On 11 April 2018 at 23:02, Bin Meng <bmeng.cn at gmail.com> wrote:
>> If CONFIG_FRAMEBUFFER_SET_VESA_MODE is not set, don't switch
>> graphics card to VESA mode. This applies to both native mode
>> and emulator mode of running the VGA BIOS.
>>
>> Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
>> ---
>>
>> Changes in v2: None
>>
>>  arch/x86/lib/bios.c             | 4 ++++
>>  drivers/bios_emulator/atibios.c | 4 ++++
>>  2 files changed, 8 insertions(+)
>
> Could this use if() instead of #ifdef ?
>

Not all of the changes can, so I chose use #ifdef

> Reviewed-by: Simon Glass <sjg at chromium.org>

Regards,
Bin


More information about the U-Boot mailing list