[U-Boot] [RFC][PATCH] cmd: fdt: Fix fdt address information after the movement

Marek Vasut marek.vasut at gmail.com
Fri Apr 13 22:07:47 UTC 2018


On 04/01/2018 04:14 PM, Simon Glass wrote:
> Hi Marek,

Hi,

> On 24 February 2018 at 19:09, Marek Vasut <marek.vasut at gmail.com> wrote:
>> From: Hiroyuki Yokoyama <hiroyuki.yokoyama.vx at renesas.com>
>>
>> This patch fixes the address information of fdt.
>>
>> wrong case:
>>  => fdt addr 0x48000000
>>  => fdt move 0x48000000 0x41000000 0xa000
>>  => fdt addr
>> The address of the fdt is 48000000
>>
>> Active address in this case is 0x41000000.
>>
>> Signed-off-by: Hiroyuki Yokoyama <hiroyuki.yokoyama.vx at renesas.com>
>> Signed-off-by: Marek Vasut <marek.vasut+renesas at gmail.com>
>> Cc: Hiroyuki Yokoyama <hiroyuki.yokoyama.vx at renesas.com>
>> Cc: Nobuhiro Iwamatsu <iwamatsu at nigauri.org>
>> Cc: Pantelis Antoniou <pantelis.antoniou at konsulko.com>
>> ---
>>  cmd/fdt.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/cmd/fdt.c b/cmd/fdt.c
>> index b783b0df42..1245bc24eb 100644
>> --- a/cmd/fdt.c
>> +++ b/cmd/fdt.c
>> @@ -204,6 +204,8 @@ static int do_fdt(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
>>                         return 1;
>>                 }
>>                 working_fdt = newaddr;
>> +               env_set_hex("fdtaddr", (ulong)working_fdt);
> 
> Shouldn't this be map_to_sysmem(working_fdt)?

Should it ?

The other question I have is, is this possibly changing the U-Boot API
and is that a problem ?

btw sorry, must've missed this mail.

-- 
Best regards,
Marek Vasut


More information about the U-Boot mailing list