[U-Boot] [PATCH] reset: fix bulk API when DM_RESET is disabled

Neil Armstrong narmstrong at baylibre.com
Tue Apr 17 07:34:18 UTC 2018


On 12/04/2018 18:41, Simon Glass wrote:
> On 12 April 2018 at 02:03, Neil Armstrong <narmstrong at baylibre.com> wrote:
>> In the commit "reset: Add get/assert/deassert/release for bulk of reset signals"
>> the disabled reset_release_bulk() and reset_get_bulk() used the wrong
>> struct clk_bulk instead of struct reset_ctl_bulk.
>>
>> Fixes: 0c28233903b5 ("reset: Add get/assert/deassert/release for bulk of reset signals")
>> Reported-by: Jean-Jacques Hiblot <jjhiblot at ti.com>
>> Signed-off-by: Neil Armstrong <narmstrong at baylibre.com>
>> ---
>>  include/reset.h | 5 +++--
>>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> Reviewed-by: Simon Glass <sjg at chromium.org>
> 
> We don't have build coverage for this at the moment I suppose. It
> would be a bit of pain to add that with sandbox, although I wonder if
> it could be done with some horrible #define hackery in a C file that
> includes this header?
> 
> - Simon
> 

It could but it will be horrible indeed.

Neil


More information about the U-Boot mailing list