[U-Boot] [PATCH 1/1] sunxi: R40: add support for gigabit ethernet

[Maxime Ripard]

Hi Lothar,

On Thu, Apr 12, 2018 at 08:19:03PM +0200, Lothar Felten wrote:
> This patch adds support for the gigabit interface found on the
> Allwinner R40/V40 CPU.
> It does not support the 100Mbit interface (EMAC).
> 
> Fixes:
> - add GMAC gating clock and reset control
> - GPIO mux settings
> - device tree entries
> 
> Tested on BananaPi M2 Berry (R40), custom board (V40).
> 
> Signed-off-by: Lothar Felten <lothar.felten at gmail.com>
> ---
>  arch/arm/dts/sun8i-r40-bananapi-m2-ultra.dts  | 14 ++++++++++
>  arch/arm/dts/sun8i-r40.dtsi                   | 37 +++++++++++++++++++++++++++
>  arch/arm/include/asm/arch-sunxi/clock_sun6i.h | 10 +++++++-
>  board/sunxi/gmac.c                            |  5 +++-
>  configs/Bananapi_M2_Ultra_defconfig           |  4 +++
>  drivers/net/sun8i_emac.c                      |  2 ++
>  6 files changed, 70 insertions(+), 2 deletions(-)

This patch looks mostly correct, but it should be split into multiple,
smaller patches, one per logical change. This would mean something like:
  - One to add the clock / reset changes
  - One to add the pinctrl change
  - One to add the DTSI bits
  - And one to enable it on the BPI M2-U (with the config and DTS changes).

Thanks!
Maxime

-- 
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180417/c0e64faa/attachment.sig>