[U-Boot] [PATCH] board: freescale: ls1012ardb: Add command to switch QSPI bank

[Prabhakar Kushwaha]

Thanks Scott for reviewing this patch

> -----Original Message-----
> From: U-Boot [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Scott
> Wood
> Sent: Friday, April 20, 2018 6:40 AM
> To: Calvin Johnson <linux.cj at gmail.com>
> Cc: U-Boot Mailing List <u-boot at lists.denx.de>
> Subject: Re: [U-Boot] [PATCH] board: freescale: ls1012ardb: Add command to
> switch QSPI bank
> 
> On Thu, 2018-04-19 at 14:09 +0530, Calvin Johnson wrote:
> > On Thu, Apr 19, 2018 at 12:17 PM, Scott Wood <oss at buserror.net> wrote:
> > > On Mon, 2018-04-16 at 08:40 +0530, Calvin Johnson wrote:
> > > > On Fri, Apr 13, 2018 at 12:18 AM, Jagdish Gediya
> > > > <jagdish.gediya at nxp.com
> > > > >
> > > > wrote:
> > > > > Add command "boot_bank X" to switch the boot bank to either
> > > > > 1 or 2.
> > > >
> > > > Are these functions required as this can be handled by new env
> > > > vars to switch banks?
> > >
> > > If you're going to add something new, a command is much more
> > > pleasant than env vars -- particularly if you stick to something
> > > like the familiar interfaces ("pix altbank", "qix altbank", etc),
> > > and include reporting of which bank was booted from if it's not
> > > there already.  Of course, a fully standardized interface would be
> > > even better.
> >
> > Yes, a fully standardized generic interface supporting all similar
> > platforms with multiple banks
> 
> And other boot sources such as NAND and MMC.


LS1012A has only one boot source i.e. QSPI

> 
> > would be better. What this patch currently does can be done with
> > simple env vars, like :
> >
> > setenv boot_bank_1 'i2c mw 0x24 0x7 0xfc; i2c mw 0x24 0x3 0xf5'
> > setenv boot_bank_2 'i2c mw 0x24 0x7 0xfc; i2c mw 0x24 0x3 0xf4'
> 
> ...if the user knows to env reset those variables after the update (versus
> something that shows up in help), and if they don't get corrupted in a multi-
> user board farm environment, etc.
> 

With env there is always a probability of getting erased. In that case user will not have these commands.

Better approach should be command which is always available. If required we can update the doc.  

--pk