[U-Boot] [PATCH v2 2/2] arm: Make arch specific memcpy thumb-safe.

[Christoph Müllner]

> On 21 Apr 2018, at 15:24, Måns Rullgård <mans at mansr.com> wrote:
> 
> Klaus Goger <klaus.goger at theobroma-systems.com> writes:
> 
>> The current arch implementation of memcpy cannot be called
>> from thumb code, because it does not use bx instructions on return.
>> This patch addresses that. Note, that this patch does not touch
>> the hot loop of memcpy, so performance is not affected.
>> 
>> Tested on MXS (arm926ejs) with and without thumb-mode enabled.
>> 
>> Signed-off-by: Klaus Goger <klaus.goger at theobroma-systems.com>
>> Signed-off-by: Christoph Muellner <christoph.muellner at theobroma-systems.com>
> 
> There are many more instances of mov to pc that ought to be fixed too.
> Why not do them all at once rather than picking them off one by one as
> they happen to break things?

I could not find exit points within memcpy other than those which we fixed.
The many other mov pc, $lr instructions are just branches within memcpy.
Am I overseeing anything here?

Thanks,
Christoph
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 874 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180421/b00e3e48/attachment.sig>