[U-Boot] [PATCH v6 1/2] x86: Add TSC-specific timer functions

Andy Shevchenko andriy.shevchenko at linux.intel.com
Mon Apr 23 08:22:44 UTC 2018


On Fri, 2018-04-20 at 11:00 -0700, Ivan Gorinov wrote:
> On Fri, Apr 20, 2018 at 06:25:08AM -0600, Andy Shevchenko wrote:

> > > -	while (rdtsc() < final_tsc)
> > > -		;

> > > +	while (rdtsc() - start_tsc < ticks);
> > 
> > I would rather preserve existing style.
> 
> OK. Existing style does not correctly handle overflow,
> but for a 64-bit counter it's a very unlikely event.

You didn't get me. I'm just talking about style, not about
functionality.

See above for lines I left in this reply.

-- 
Andy Shevchenko <andriy.shevchenko at linux.intel.com>
Intel Finland Oy


More information about the U-Boot mailing list