[U-Boot] [PATCH] video-uclass: Fix logical-not-parentheses warning

Anatolij Gustschin agust at denx.de
Tue Apr 24 19:03:11 UTC 2018


On Sun, 22 Apr 2018 09:47:48 -0400
Tom Rini trini at konsulko.com wrote:

> With clang-4.0 and later we see:
> warning: logical not is only applied to the left hand side of this bitwise
> operator [-Wlogical-not-parentheses]
>         if ((!gd->flags & GD_FLG_RELOC))
>              ^          ~
> 
> And while the compiler suggests adding parenthesis around gd->flags, a
> reading of the code says that we want to know when GD_FLG_RELOC is not
> set and then return.
> 
> Cc: Simon Glass <sjg at chromium.org>
> Cc: Anatolij Gustschin <agust at denx.de>
> Signed-off-by: Tom Rini <trini at konsulko.com>
> ---
>  drivers/video/video-uclass.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to u-boot-video/master, thanks!

--
Anatolij


More information about the U-Boot mailing list