[U-Boot] DWC3 USB driver regression

[Neil Armstrong]

Hi,

On 25/04/2018 11:09, Masahiro Yamada wrote:
> Hi Neil.
> 
> 
> 2018-04-25 17:37 GMT+09:00 Neil Armstrong <narmstrong at baylibre.com>:
>> Hi,
>>
>> On 25/04/2018 06:21, Masahiro Yamada wrote:
>>> Hi.
>>>
>>>
>>> I found DWC3 usb driver on UniPhier SoC family
>>> not working.
>>>
>>>
>>> I did git-bisect, and the first bad commit is
>>>
>>>
>>> 7c839ea70c4991e8d4c322e074359ac5e155d59d is the first bad commit
>>> commit 7c839ea70c4991e8d4c322e074359ac5e155d59d
>>> Author: Neil Armstrong <narmstrong at baylibre.com>
>>> Date:   Wed Apr 11 17:08:01 2018 +0200
>>>
>>>     usb: host: dwc3: Add support for multiple PHYs
>>>
>>>     DWC3 Ips can have more than 1 PHY for USB2 and 1 PHY for USB3, add support
>>>     for a generic number of PHYs and adapt the code to handle a generic
>>>     number of PHYs.
>>>
>>>     Signed-off-by: Neil Armstrong <narmstrong at baylibre.com>
>>>
>>>
>>>
>>>
>>> If I revert this commit, I can get the USB on my board working.
>>>
>>> Any insight about the cause of the problem?
>>>
>>>

[...]

> 
> 
> Yeah, it fixed the problem.
> 
> In my case, the "phy" property is missing in the DWC3 node,
> so dev_count_phandle_with_args() returns a negative error code.
> 
> Thanks.


I sent a "usb: host: dwc3: fix phys init" patch, can you test it and report the test result for Marek ?

Thanks for testing,
Neil