[U-Boot] [RFC PATCH 2/2] arm64: zynqmp: Try to create bootcm_mmcX at run time

[Michal Simek]

On 26.4.2018 08:23, Alexander Graf wrote:
> 
> 
> On 25.04.18 14:38, Michal Simek wrote:
>> Just an attept to create boot commands for mmcs above 2 which is not
>> generated.
>>
>> Signed-off-by: Michal Simek <michal.simek at xilinx.com>
>> ---
>>
>> Probably some ifdefs around are missing.
>> ---
>>  board/xilinx/zynqmp/zynqmp.c    | 28 ++++++++++++++++++++++++++++
>>  include/configs/xilinx_zynqmp.h |  7 -------
>>  2 files changed, 28 insertions(+), 7 deletions(-)
>>
>> diff --git a/board/xilinx/zynqmp/zynqmp.c b/board/xilinx/zynqmp/zynqmp.c
>> index 96ea0f578d30..37fa8f4f4d3f 100644
>> --- a/board/xilinx/zynqmp/zynqmp.c
>> +++ b/board/xilinx/zynqmp/zynqmp.c
>> @@ -451,6 +451,32 @@ void reset_cpu(ulong addr)
>>  {
>>  }
>>  
>> +static int create_mmc_boot_commands(void)
>> +{
>> +/* Size of strings below + one terminating char \0 + 3 possitions for seq */
>> +#define MAX_COMMAND_LEN	15
>> +#define MAX_BODY_LEN	32
>> +
>> +	int ret;
>> +	struct uclass *uc;
>> +	struct udevice *dev;
>> +	char body[MAX_BODY_LEN];
>> +	char command[MAX_COMMAND_LEN];
>> +
>> +	ret = uclass_get(UCLASS_MMC, &uc);
>> +	if (ret)
>> +		return ret;
>> +
>> +	uclass_foreach_dev(dev, uc) {
>> +		snprintf(body, MAX_BODY_LEN, "setenv devnum %x; run mmc_boot",
>> +			 dev->seq);
>> +		snprintf(command, MAX_COMMAND_LEN, "bootcmd_mmc%x", dev->seq);
>> +		env_set(command, body);
>> +	}
> 
> Why not just remove the ones you don't need? You could leave the
> template in and just remove bootcmd_mmc0 if you don't see an mmc0 device.

It is not a problem if that alias is mmc0 or mmc1 but if that alias is
mmc3 because none is generating that distro default boot command line.
Look at my reply on 1/2

M