[U-Boot] [PATCH] regmap: add regmap_update_bits() helper

[Simon Glass]

Hi Neil,

On 23 April 2018 at 08:16, Neil Armstrong <narmstrong at baylibre.com> wrote:
> Add the regmap_update_bits() to simply the read/modify/write of registers
> in a single command. The function is taken from Linux regmap
> implementation.
>
> Signed-off-by: Neil Armstrong <narmstrong at baylibre.com>
> ---
>  include/regmap.h | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
>
> diff --git a/include/regmap.h b/include/regmap.h
> index 493a5d8..3c463e9 100644
> --- a/include/regmap.h
> +++ b/include/regmap.h
> @@ -47,6 +47,29 @@ int regmap_read(struct regmap *map, uint offset, uint *valp);
>         regmap_read(map, (uint32_t *)(ptr)->member - (uint32_t *)(ptr), valp)
>
>  /**
> + * regmap_update_bits() - Perform a read/modify/write using a mask
> + *
> + * @map:       The map returned by regmap_init_mem*()
> + * @offset:    Offset of the memory
> + * @mask:      Mask to apply to the read value
> + * @val:       Value to apply to the value to write
> + */
> +static inline int regmap_update_bits(struct regmap *map, uint offset,
> +                                    uint mask, uint val)

Why is this inline? I think it would save code size to make it a
normal function.

Also can you add a call to this function somewhere for sandbox, as a test?

> +{
> +       uint reg;
> +       int ret;
> +
> +       ret = regmap_read(map, offset, &reg);
> +       if (ret)
> +               return ret;
> +
> +       reg &= ~mask;
> +
> +       return regmap_write(map, offset, reg | val);
> +}
> +
> +/**
>   * regmap_init_mem() - Set up a new register map that uses memory access
>   *
>   * Use regmap_uninit() to free it.
> --
> 2.7.4
>

Regards,
Simon