[U-Boot] [PATCH v6 8/8] armv8: ls1046a: setup SEC ICIDs and fix up device tree

[Laurentiu Tudor]

Hi Horia,

> -----Original Message-----
> From: Horia Geanta
> 
> On 7/31/2018 5:53 PM, laurentiu.tudor at nxp.com wrote:
> > From: Laurentiu Tudor <laurentiu.tudor at nxp.com>
> >
> > Add support for SEC ICID configuration and apply it for ls1046a.
> > Also add code to make the necessary device tree fixups.
> >
> > Signed-off-by: Laurentiu Tudor <laurentiu.tudor at nxp.com>
> Reviewed-by: Horia Geantă <horia.geanta at nxp.com>

Thanks!

> [snip]
> > +#define SET_SEC_RTIC_ICID_ENTRY(rtic_num, streamid) \
> > +	SET_ICID_ENTRY(NULL, streamid, (((streamid) << 16) | (streamid)), \
> > +		offsetof(ccsr_sec_t, rticliodnr[rtic_num].ls) + \
> > +		CONFIG_SYS_FSL_SEC_ADDR, 0)
> > +
> RTIC nodes have a binding doc in Linux kernel:
> Documentation/devicetree/bindings/crypto/fsl-sec4.txt
> 
> Thus, in theory, "fsl,sec-v4.0-rtic-memory" could be used instead of NULL for
> the compat string.
> PPC code in arch/powerpc/include/asm/fsl_liodn.h does this.

I also noticed that. However I've decided to go with NULL instead of specifying the compat string because currently we don't have the RTIC nodes in the device trees.

---
Best Regards, Laurentiu